grayskull icon indicating copy to clipboard operation
grayskull copied to clipboard

[FEATURE] Add support for new output format

Open marcelotrevisani opened this issue 1 year ago • 9 comments

https://github.com/prefix-dev/recipe-format

Add feature to generate recipe in this new format.

cc: @wolfv @ocefpaf

It would be nice to add more examples so it would be easier to add this. :)

marcelotrevisani avatar Sep 15 '23 15:09 marcelotrevisani

Awesome! Would love to see this. We don't have so many examples of the new format available yet. We have some examples of the previous variant in the emscripten-forge and boa-forge repositories:

  • https://github.com/mamba-org/boa-forge
  • https://github.com/emscripten-forge/recipes

wolfv avatar Sep 18 '23 15:09 wolfv

Currently using grayskull + boa convert + some sed to feed the new recipe to rattler-build. Would love to have support in grayskull directly :-)

If nobody started working on this yet, I could give it a try in the coming weeks (no promise). Haven't looked yet, but should most work be in https://github.com/marcelotrevisani/souschef ?

beenje avatar Jan 15 '24 13:01 beenje

That would be amazing. No one is working on it afaik :)

wolfv avatar Jan 15 '24 13:01 wolfv

Now that the conda-recipe-manager is up and running with conversion integration tests with rattler-build, should we consider having grayskull incorporate conda-recipe-manager as the translation layer? At least as a first-pass implementation?

schuylermartin45 avatar May 09 '24 16:05 schuylermartin45

Yes, sure I just don't have the capacity now for that, due to some personal and work obligations. However, I can review the PR If you would like to give a try please let me know :)

marcelotrevisani avatar May 09 '24 16:05 marcelotrevisani

I might be able to start on this next week. I have some low-hanging fruit that'll improve compatibility with rattler-build I want to address and then I should be free to take a look.

schuylermartin45 avatar May 10 '24 14:05 schuylermartin45

Not to set myself up for failure, but this looks relatively straight-forward so far. This will be the first project that consumes conda-recipe-manager, so I'm sure there will be some unexpected hurdles.

My current plan is to add a new flag to grayskull. If it is set, perform the conversion in utils.generate_recipe() before we dump the recipe contents. I'll also automatically use recipe.yaml over meta.yaml where applicable.

schuylermartin45 avatar May 16 '24 15:05 schuylermartin45

I put up a draft PR until I can get unblocked on a few things. See my PR description for more details.

schuylermartin45 avatar May 16 '24 20:05 schuylermartin45

I put up a draft PR until I can get unblocked on a few things. See my PR description for more details.

This PR is now out of Draft. I found a workaround to the plugin issue I was encountering.

schuylermartin45 avatar Jun 18 '24 19:06 schuylermartin45