constructor icon indicating copy to clipboard operation
constructor copied to clipboard

fail with better error message

Open joamatab opened this issue 2 years ago • 5 comments
trafficstars

Checklist

  • [X] I added a descriptive title
  • [X] I searched open reports and couldn't find a duplicate

What happened?

How could we fail with a more descriptive error messages?

https://github.com/gdsfactory/gdsfactory/actions/runs/4276066747/jobs/7443895099

Conda Info

No response

Conda Config

No response

Conda list

No response

Additional Context

No response

joamatab avatar Feb 26 '23 18:02 joamatab

It's a conda incompatibility. This needs repodata patches that haven't been merged on defaults (but conda-forge works):

  • https://github.com/AnacondaRecipes/repodata-hotfixes/pull/180

You can pin conda <23.1 for now in your CI.

jaimergp avatar Feb 27 '23 16:02 jaimergp

or you enforce a newer constructor version where this always was correctly pinned: e.g. conda install "constructor>=3.4.2" or conda env create --name constructor "constructor>=3.4.2".

dbast avatar Feb 28 '23 10:02 dbast

I tried both pinning conda or enforcing constructor version and the issue persists

https://github.com/gdsfactory/gdsfactory/actions/runs/4396097366/jobs/7698325611

it's interesting that it still builds on windows

joamatab avatar Mar 12 '23 06:03 joamatab

Seems like with a completely different error... not able to resolve dependencies.

Can you replace the line in https://github.com/gdsfactory/gdsfactory/actions/runs/4396097366/jobs/7698325611

  • conda install "constructor>=3.4.2" -y with e.g. conda create --name constructor "constructor>=3.4.2" -y instead of installing into an existing environment.

Also then requires a conda activate constructor before running constructor.

dbast avatar Mar 16 '23 17:03 dbast

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include: - What OS and version you reproduced the issue on - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar Mar 16 '24 04:03 github-actions[bot]