constructor icon indicating copy to clipboard operation
constructor copied to clipboard

NSIS has a 2GB installer size limit

Open jaimergp opened this issue 2 years ago • 2 comments

Checklist

  • [X] I added a descriptive title
  • [X] I searched open reports and couldn't find a duplicate

What happened?

Comes from https://github.com/mne-tools/mne-installers/pull/168#issuecomment-1433568454. Thanks @larsoner and @hoechenberger for the research.

nsis has a 2GB limit file size. This can be hit if your project adds big things like pytorch, cudatoolkit and others.

There are nsis-derivatives like nsisbi which can increase this limit to 4GB with some trickery, and beyond that with an external file. I don't know how to feel about using nsisbi by default, but we might be able to enable this with a flag, or a new installer_type or something (large-exe?).

Conda Info

No response

Conda Config

No response

Conda list

No response

Additional Context

No response

jaimergp avatar Feb 22 '23 12:02 jaimergp

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include: - What OS and version you reproduced the issue on - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar Feb 23 '24 04:02 github-actions[bot]

not stale

jaimergp avatar Feb 23 '24 14:02 jaimergp