Investigate error levels in NSIS

[jaimergp]

Shared by @elovelan in https://github.com/ScoopInstaller/Extras/pull/10457#issuecomment-1425155797

@jaimergp, the NSIS docs indicate that NSIS should be able to return a failure exit code. I'm happy to dig into this more if there's a chance that updating constructor might resolve it. I realize that may be a risky proposition however if any software is relying on it always having a return code of 0, so I'm also happy to continue down the path of your original suggestion.

[github-actions[bot]]

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

1. Verify that you can still reproduce the issue at hand
2. Comment that the issue is still reproducible and include: - What OS and version you reproduced the issue on - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

[jaimergp]

not stale