constructor icon indicating copy to clipboard operation
constructor copied to clipboard

Investigate uninstaller tests on Windows hanging if the path contains spaces

Open jaimergp opened this issue 2 years ago • 1 comments

See https://github.com/conda/constructor/pull/449#issuecomment-1369903905 (note it might be hidden). Copying here for reference:

The win un-installers fail (run forever if not killed by the p.communicate(timeout)).... still all files seem to be removed. Reverting back to an env_dir without space makes it finish without timeout

and

This PR was created and afaik running green before the uninstaller test PR was merged https://github.com/conda/constructor/pull/569

Now with the uninstaller test PR merged, there is the following situation:

  • the windows uninstallers hang consuming lots of action runner minutes without deleting anything
  • Added a timeout to the test command execution which is visible in the test execution log
  • If the spaces are removed on windows, then the installers won't hang.
  • Spaces on windows should (!?) work anyway already due to windows having spaces in path since long... like C:\Program Files\...
  • The uninstallers even hang when commenting almost everything out in the uninstall section in main.nsi.tmpl, see tests done here https://github.com/dbast/constructor/pull/3

jaimergp avatar Jan 10 '23 17:01 jaimergp