conda-package-handling icon indicating copy to clipboard operation
conda-package-handling copied to clipboard

Add `assert packages match` function to replace odd old API

Open dholth opened this issue 1 year ago • 1 comments

Checklist

  • [X] I added a descriptive title
  • [X] I searched open requests and couldn't find a duplicate

What is the idea?

We have a validate_converted_files_match_streaming function in validate.py with a weird interface "returns details about mismatched files", that exists only to support the existing transmute CLI function.

There is no reason to convert a .conda to .tar.bz2 and then need details about which files did not convert correctly. Instead, an exception should be raised an the faulty file should be deleted. The assertion-style interface will be easier to use compared to checking that the list of differences is empty.

dholth avatar May 05 '23 13:05 dholth

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include: - What OS and version you reproduced the issue on - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar May 05 '24 04:05 github-actions[bot]