conda-docs icon indicating copy to clipboard operation
conda-docs copied to clipboard

Published 20 hours ago • verified publisher icon conda

Duplicated contributing page is out of sync with conda/conda

Open jaimergp opened this issue 3 years ago • 5 comments

This repo lists a contributing.rst file that is shown in the conda.io website.

conda/conda has a very similar one which has been recently updated and is not shown in any website (fix for that in https://github.com/conda/conda/pull/11041).

I suggest both are integrated, conda/conda being the source of truth.

jaimergp avatar Nov 15 '21 17:11 jaimergp

I like that idea, thanks for raising this @jaimergp!

jezdez avatar Nov 16 '21 17:11 jezdez

11041 now contains the CLA iframe too so this one can be removed. For SEO reasons the link should still point to the conda/conda one though.

jaimergp avatar Nov 18 '21 19:11 jaimergp

For the record, we removed the iframe in conda/conda a while ago since it didn't fully work for various reasons on all browsers and GitHub also doesn't render it as part of the regular page rendering. It's okay to have it simply linked from the document.

jezdez avatar Nov 19 '21 22:11 jezdez

@jezdez, if we consolidate our docs to a single docs site (like we are planning to do here: #777), does it render this ticket defunct? If so, it would be nice to close this issue.

travishathaway avatar May 20 '22 14:05 travishathaway

Yeah, that's the plan, but I only wanted to close it when we actually combine it.

jezdez avatar May 20 '22 14:05 jezdez