conda-build icon indicating copy to clipboard operation
conda-build copied to clipboard

Only fetch lfs files for specific git_ref

Open Tobias-Fischer opened this issue 11 months ago • 6 comments

Description

Currently conda-build fetches all lfs files that ever existed in the history. This is not necessary, and as outlined in https://github.com/conda/conda-build/issues/4809 is costly when e.g. using GitHub. For the specific use case that I have in mind (see https://github.com/RoboStack/ros-humble/pull/155), the lfs files were actually removed from the repository and moved elsewhere (as the GitHub limits were exceeded, and now require payment), but the conda build still fails.

We already have the git_ref that we are interested in, so this is a relatively minor change; much smaller than making git-lfs completely optional as suggested in https://github.com/conda/conda-build/issues/4809

Checklist - did you ...

  • [x] Add a file to the news directory (using the template) for the next release's release notes?
  • [x] Add / update necessary tests?
  • [x] Add / update outdated documentation?

Tobias-Fischer avatar Feb 29 '24 00:02 Tobias-Fischer

We require contributors to sign our Contributor License Agreement and we don't have one on file for @Tobias-Fischer.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (https://github.com/conda/infrastructure/pull/881), and ping the bot to refresh the PR.

conda-bot avatar Feb 29 '24 00:02 conda-bot

@conda-bot check

kenodegard avatar Feb 29 '24 00:02 kenodegard

Hi @kenodegard - any chance to run this again, please?

Tobias-Fischer avatar Feb 29 '24 03:02 Tobias-Fischer

I think this is ready to go - all CI failures are unrelated :)

Tobias-Fischer avatar Feb 29 '24 04:02 Tobias-Fischer

A quick reminder @kenodegard :)

Tobias-Fischer avatar Mar 07 '24 05:03 Tobias-Fischer

@Tobias-Fischer thanks for checking in, we're still working to resolve the unrelated test failures caused by upstream deprecations, once we untangle that we'll get this moving again

kenodegard avatar Mar 07 '24 16:03 kenodegard

CodSpeed Performance Report

Merging #5202 will not alter performance

Comparing Tobias-Fischer:patch-1 (5a66529) with main (ab137d2)

Summary

✅ 3 untouched benchmarks

codspeed-hq[bot] avatar Mar 25 '24 15:03 codspeed-hq[bot]