conda-build icon indicating copy to clipboard operation
conda-build copied to clipboard

Include file contents when generating file hash

Open timkpaine opened this issue 1 year ago • 5 comments

Description

Include file contents when generating file hash, in case different files have the same contents.

Fixes: https://github.com/conda/conda-build/issues/4814 Xref: https://github.com/conda-forge/staged-recipes/pull/22323

Checklist - did you ...

  • [ ] Add a file to the news directory (using the template) for the next release's release notes?
  • [x] Add / update necessary tests?

I'm not sure how / where to test this, please advise.

  • [x] Add / update outdated documentation?

timkpaine avatar Mar 23 '23 20:03 timkpaine

We require contributors to sign our Contributor License Agreement and we don't have one on file for @timkpaine.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

conda-bot avatar Mar 23 '23 20:03 conda-bot

@conda/builds-tools Any suggestion where @timkpaine could add a test for this?

jezdez avatar Jan 25 '24 09:01 jezdez

CodSpeed Performance Report

Merging #4821 will not alter performance

Comparing timkpaine:tkp/4814 (312c888) with main (01b47f4)

Summary

✅ 3 untouched benchmarks

codspeed-hq[bot] avatar Mar 18 '24 15:03 codspeed-hq[bot]

pre-commit.ci autofix

isuruf avatar Mar 19 '24 14:03 isuruf

Ready for review @conda/builds-tools

isuruf avatar Apr 17 '24 14:04 isuruf