conda-build icon indicating copy to clipboard operation
conda-build copied to clipboard

Added missing activate_in_script in allowed FIELDS

Open npanpaliya opened this issue 2 years ago • 7 comments

Description

activate_in_script is missing from FIELDS because of which conda_build.api.check was failing for recipes having activate_in_script in the build section.

Checklist - did you ...

  • [ ] Add a file to the news directory (using the template) for the next release's release notes?
  • [ ] Add / update necessary tests?
  • [ ] Add / update outdated documentation?

npanpaliya avatar Feb 13 '23 06:02 npanpaliya

We require contributors to sign our Contributor License Agreement and we don't have one on file for @npanpaliya.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

conda-bot avatar Feb 13 '23 06:02 conda-bot

I've signed the CLA.

npanpaliya avatar Feb 13 '23 09:02 npanpaliya

I've followed the steps of signing CLA twice, still the PR check shows as failed.

npanpaliya avatar Feb 15 '23 13:02 npanpaliya

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar Feb 16 '24 04:02 github-actions[bot]

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar Feb 16 '24 04:02 github-actions[bot]

CodSpeed Performance Report

Merging #4771 will not alter performance

Comparing npanpaliya:add-activate-in-script (54b214a) with main (51f81ce)

Summary

✅ 3 untouched benchmarks

codspeed-hq[bot] avatar Mar 25 '24 16:03 codspeed-hq[bot]

The tests are failing because setting the field type to bool changes the default value for build/activate_in_script to False. Without setting the field type the default value is None which translates to True in MetaData.activate_in_script.

kenodegard avatar Mar 25 '24 17:03 kenodegard