conda-build icon indicating copy to clipboard operation
conda-build copied to clipboard

[DOC] Add note about non-git local source location needing to be within the feedstock directory tree

Open bskinn opened this issue 2 years ago • 5 comments

Description

Based on recent personal experience, when building with an unpacked sdist that's not a git repository, in order for the source to be visible inside the docker container it appears to have to reside inside the feedstock directory tree.

That is, the build only worked when I unpacked the sdist in {repo}/recipe/{sdist unpack}. If I used an unpack location outside {repo}/recipe, the build would fail at the cp -a ... step.

NB: I didn't try unpacking it as {repo}/{sdist unpack}.

NB also, I didn't try to build using a git repo housed outside the repository.


I'm aiming this PR to clarify this requirement for the location of the source on the local filesystem.

If this is not actually supposed to be a requirement, then this PR should probably be a bug ticket, instead. Happy to put it wherever's best, and happy to do further testing if needed.

Checklist - did you ...

  • [ ] Add a file to the news directory (using the template) for the next release's release notes?
  • [x] Add / update necessary tests? (N/A)
  • [x] Add / update outdated documentation?

bskinn avatar Nov 30 '22 19:11 bskinn

We require contributors to sign our Contributor License Agreement and we don't have one on file for @bskinn.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

conda-bot avatar Nov 30 '22 19:11 conda-bot

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar Dec 01 '23 04:12 github-actions[bot]

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar Dec 01 '23 04:12 github-actions[bot]

Weird, I completely missed the CLA comment, even though it clearly came into my email.

CLA signed.

bskinn avatar Dec 01 '23 04:12 bskinn

@conda-bot check

beeankha avatar May 09 '24 20:05 beeankha