conda-build icon indicating copy to clipboard operation
conda-build copied to clipboard

Get stdlib dir searches for py ver

Open ScottBailey opened this issue 2 years ago • 1 comments

Description

The function get_stdlib_dir(prefix, py_ver) initially used py_ver only in the case where directories weren't found. This could result in the case where 2 or more python versions existed and the function simply took the first version.

This change modifies the function to test for the existence of <lib_dir>/python<py_ver>. If so, we simply return that as the stdlib path.

This is a relatively insignificant change, so I don't think it needs to go in bugfixes. I found and tested this change building Anaconda mxnet 1.5.1 with opencv 4.6.0-0. I think this is a corner case "defect" and probably doesn't require a specific test case.

It's probably more interesting as an optimization than anything else.

Checklist - did you ...

  • [x] Add a file to the news directory (using the template) for the next release's release notes?
  • [x] Add / update necessary tests?
  • [x] Add / update outdated documentation?

ScottBailey avatar Sep 28 '22 17:09 ScottBailey

We require contributors to sign our Contributor License Agreement and we don't have one on file for @ScottBailey.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

conda-bot avatar Sep 28 '22 17:09 conda-bot

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar Oct 01 '23 04:10 github-actions[bot]

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar Oct 01 '23 04:10 github-actions[bot]