conda-build icon indicating copy to clipboard operation
conda-build copied to clipboard

Rename variables named `white*` to `allow*`

Open kenodegard opened this issue 2 years ago • 4 comments

Description

Derived from our inclusive language efforts (see https://github.com/conda/conda-build/issues/4494 and 7.1 of our styleguide).

@kenodegard said in https://github.com/conda/conda-build/issues/4494#issuecomment-1195559278: There are two white* variables in conda-build, both are recipe keywords: missing_dso_whitelist and runpath_whitelist.

Both keywords are also in use in mamaba/boa so we will need to offer similar modifications there.

Furthermore, since conda-build doesn't have an aliasing system like conda.base.context.Context does, this becomes a large enough change that I'm wondering if we should backlog the allow/deny rewording for now?

At the very least, the allow/deny rewording should be spun off from this epic into a separate effort.

kenodegard avatar Jul 27 '22 13:07 kenodegard

@jezdez, how do you think we should approach this one?

jakirkham avatar Feb 07 '23 23:02 jakirkham

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include: - What OS and version you reproduced the issue on - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar Feb 08 '24 04:02 github-actions[bot]

Not stale

jakirkham avatar Feb 08 '24 04:02 jakirkham

Quick note: The new recipe format Conda Enhancement Proposal (CEP 14) utilizes missing_dso_allowlist and rpath_allowlist as keys instead of missing_dso_allowlist and runpath_whitelist:

Screenshot 2024-04-19 at 3 02 49 PM

beeankha avatar Apr 19 '24 19:04 beeankha