conda-build icon indicating copy to clipboard operation
conda-build copied to clipboard

Change line endings from LF to CRLF when writing build scripts on Win…

Open kevarding opened this issue 2 years ago • 1 comments

Resolve #4521 by changing LF line endings to CRLF in the function write_build_scripts from the windows.py module. (Assuming that it is this simple and that the change won't break anything else)

kevarding avatar Jul 01 '22 22:07 kevarding

We require contributors to sign our Contributor License Agreement and we don't have one on file for @kevarding.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

conda-bot avatar Jul 01 '22 22:07 conda-bot

Encountered the same problem. And this patch works.

EzioHelios avatar Oct 12 '22 05:10 EzioHelios

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar Oct 13 '23 04:10 github-actions[bot]