conda-build
conda-build copied to clipboard
Fixes the git lfs error by adding git lfs fetching
This PR addresses issue #1462 and is a part of the solution that fixes the failing clone from a source with LFS files. I have added a runtime check if the repo uses git lfs and a git lfs fetch call that fetches all LFS files, so it can be copied to the destination directory later on.
We require contributors to sign our Contributor License Agreement, and we don't have one on file for @ernstluring. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.
@anaconda-issue-bot check
Any idea why the pipelines fail? Is it because git lfs
on CI is not the correct version?
@jezdez Is there anything I can do to bring this over the finish line? I also run into the problem today and would like to get it fixed.
pre-commit.ci autofix
This update has monetary implications for anyone using conda-build with GIT LFS. Using LFS with GitHub, for instance, costs money. If someone is using conda-build for each commit but isn't already using LFS as part of their checks (build, test, etc), this update is going to start downloading LFS files for those users.
This feature should be opt-in by default.
Would it make sense to convert this request to an issue?
I'm still seeing an error with conda-build 3.24.0 related to a git_url:
source. I left a comment in https://github.com/conda/conda-build/issues/1462, but happy to open a new issue.
Yeah a new issue sounds like a good idea (just to make sure that doesn't get lost in a closed one)
Yeah a new issue sounds like a good idea (just to make sure that doesn't get lost in a closed one)
#4882