conda-build icon indicating copy to clipboard operation
conda-build copied to clipboard

Published 20 hours ago • verified publisher icon conda

Master.nupatch

Open mingwandroid opened this issue 4 years ago • 8 comments

mingwandroid avatar Oct 07 '20 08:10 mingwandroid

@isuruf and @mbargull, am I correct in this change? selectors isn't meant to mean 'selectors only' is it? If so I'd like to disambiguate that from 'selectors also' and check each usage.

mingwandroid avatar Oct 13 '20 04:10 mingwandroid

For me, the used vars are coming up empty without this change.

mingwandroid avatar Oct 13 '20 04:10 mingwandroid

It is supposed to mean selectors only. First we get the used selectors, then apply the selectors, then get the rest of the used vars. If it wasn't, we'd be marking some vars as used which are hidden behind a selector that evaluates to False.

isuruf avatar Oct 13 '20 04:10 isuruf

OK, I've figured out what was wrong, hopefully this doesn't break anything. Please check the latest commit message for details.

mingwandroid avatar Oct 13 '20 05:10 mingwandroid

Looks good to me

isuruf avatar Oct 13 '20 05:10 isuruf

Thanks @isuruf. Also, can you review the new patching stuff? The output is silly egomania, but the idea is solid! I'll come up with a key which doesn't encode to RAYMD1LOVE when all is good later!

We need a new CB release soon.

mingwandroid avatar Oct 13 '20 05:10 mingwandroid

RAYMD1LOVE

:smile:

I have very limited experience in using patch. Sorry, I'm not going to be useful reviewing that.

isuruf avatar Oct 13 '20 05:10 isuruf

OK, the other thing I've slipped in here is: Add --build-id-pat option (WIP), I'm not really happy with the quality of that code so I may remove it from this PR.

mingwandroid avatar Oct 13 '20 05:10 mingwandroid

superseded by:

  • #4092
  • 94c16481

kenodegard avatar Jun 13 '23 05:06 kenodegard