conda-build
conda-build copied to clipboard
conda
downstreams source_files test for copying
adding new unit test to ensure downstream source files are copied correctly to fix issues https://github.com/conda-forge/cspice-feedstock/pull/14 and https://github.com/conda/conda-build/issues/3795
I may need to duplicate logic from test_copy_test_source_files
This is currently a work in progress (WIP) branch, not intended to be merged in as is. I hope to make the test replicate the issues I am running into, and for this PR to include the fix eventually.
Hopefully more experienced conda-build maintainers and contributors can help narrow down the issue, as the functions involved are not documented well enough for me to fully understand what is going on.
It looks like I am successfully reproducing the bug in this PR. The lack of failures on macos appear to be due to many tests being skipped in macos (the new tests are not executed in macos builds)
Hi @AndrewAnnex , thanks for the tests really appreciate that! Are you going to try to fix it?
I think it is fair game for someone else to fix, I tried for an hour or so when I first posted the issue, but the codebase isn’t documented enough for me to make any progress. In any case I won’t have a chance to look at it for another week or so.
-Andrew Annex
On Jan 3, 2020, at 11:42 AM, Marcelo Duarte Trevisani [email protected] wrote:
Hi @AndrewAnnex , thanks for the tests really appreciate that! Are you going to try to fix it?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
I know there is no solution being proposed in this pull request (I have asked for assistance), but maybe it is better to have a failing test in the codebase to motivate future debugging than just leaving it in a PR.
So if it can be merged in that would be great, or I can also update the PR with the correct pytest assertion to capture that this is a known failing test
If you can mark it as @pytest.mark.xfail I will merge it and take this on. Thanks.
@mingwandroid done! or at least I believe so, thanks for looking into it