conda-mirror icon indicating copy to clipboard operation
conda-mirror copied to clipboard

Rename blacklist

Open ericdill opened this issue 4 years ago • 5 comments

Language matters. https://twitter.com/leahculver/status/1269109776983547904 https://twitter.com/alessandramakes/status/1269116696834437121

I'd also be in ok with any of these *-list prefixes:

  • go / green / nice / safe
  • stop / red / naughty

This introduces a rename of blacklist -> denylist and whitelist -> allowlist. Backwards compatibility is enabled until such a time as we want to get rid of the backwards compat layer. In the warning message it says "until the next minor release", but that's sort of up to you all since you own the fork now.

ericdill avatar Jun 06 '20 20:06 ericdill

As a frequent user of this package I strongly support this idea.

FaustinCarter avatar Jun 06 '20 20:06 FaustinCarter

Codecov Report

Merging #11 into master will decrease coverage by 1.08%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   90.36%   89.27%   -1.09%     
==========================================
  Files           3        3              
  Lines         415      429      +14     
==========================================
+ Hits          375      383       +8     
- Misses         40       46       +6     
Impacted Files Coverage Δ
conda_mirror/conda_mirror.py 87.30% <80.00%> (-1.37%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15287b6...31ee5e2. Read the comment docs.

codecov[bot] avatar Jun 07 '20 20:06 codecov[bot]

What about using the more common terms include and exclude?

xhochy avatar Jun 08 '20 12:06 xhochy

@xhochy i'd be fine with those too

ericdill avatar Jun 08 '20 17:06 ericdill

The code has changed enough that this pull request should be closed and do this over. I am definitely in favor of just using include and exclude. I think we should also support dependencies using the same format as in conda environment files.

analog-cbarber avatar Jul 08 '21 12:07 analog-cbarber