staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Adding optunahub

Open c-bata opened this issue 1 year ago • 14 comments

Checklist

  • [x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [x] License file is packaged (see here for an example).
  • [x] Source is from official source.
  • [x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [x] If static libraries are linked in, the license of the static library is packaged.
  • [x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • [x] Build number is 0.
  • [x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [x] When in trouble, please check our knowledge base documentation before pinging a team.

c-bata avatar Mar 21 '25 04:03 c-bata

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/optunahub/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: contramundum53, HideakiImamura, not522, nabenabe0928, toshihikoyanase, y0z. Please ask them to comment on this PR if they are.

github-actions[bot] avatar Mar 21 '25 04:03 github-actions[bot]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/optunahub/meta.yaml) and found some lint.

Here's what I've got...

For recipes/optunahub/meta.yaml:

  • ❌ The home item is expected in the about section.
  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.

For recipes/optunahub/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ The recipe is not parsable by parser conda-forge-tick (the bot). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13984876898. Examine the logs at this URL for more detail.

conda-forge-admin avatar Mar 21 '25 04:03 conda-forge-admin

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/optunahub/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/optunahub/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13984935359. Examine the logs at this URL for more detail.

conda-forge-admin avatar Mar 21 '25 04:03 conda-forge-admin

Thanks for inviting me. I would like to become a maintainer.

HideakiImamura avatar Mar 21 '25 09:03 HideakiImamura

👍

not522 avatar Mar 21 '25 09:03 not522

👍

y0z avatar Mar 21 '25 10:03 y0z

👍

contramundum53 avatar Mar 24 '25 05:03 contramundum53

Thank you for including me as a maintainer:)

nabenabe0928 avatar Mar 24 '25 05:03 nabenabe0928

@conda-forge/help-python this PR is ready for review. I think the CI will be fixed by re-run since all maintainers commented on this pull request now.

c-bata avatar Mar 24 '25 05:03 c-bata

Sorry, I've noticed that docker build is failed due to the following error. I will address this issue and make this pr ready for review again.

Could not solve for environment specs
The following package could not be installed
└─ ga4mp =* * does not exist (perhaps a typo or a missing channel).

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1204458&view=logs&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff

c-bata avatar Mar 26 '25 07:03 c-bata

The CI failures seem to be caused by ga4mp being available only on PyPI and not registered on conda-forge, as indicated by the error message below:

Could not solve for environment specs
The following package could not be installed
└─ ga4mp =* * does not exist (perhaps a typo or a missing channel).

According to the documentation, dependencies outside of the conda-forge channel should be avoided.

@conda-forge/help-python Is my understanding correct? If so, I will discuss with optunahub developers the possibilities of removing ga4mp dependency or requesting ga4mp devs to provide conda-forge packages.

c-bata avatar Mar 27 '25 02:03 c-bata

Hi! This is the staged-recipes linter and your PR looks excellent! :rocket:

github-actions[bot] avatar Jun 27 '25 05:06 github-actions[bot]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/optunahub/meta.yaml) and found it was in an excellent condition.

conda-forge-admin avatar Jun 27 '25 05:06 conda-forge-admin

All CI checks have passed now.

@conda-forge/help-python this PR is ready for review.

c-bata avatar Jun 27 '25 06:06 c-bata