staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Add PyWLGK to the conda-forge channel

Open Old-Shatterhand opened this issue 1 year ago • 4 comments

Checklist

  • [X] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [X] License file is packaged (see here for an example).
  • [X] Source is from official source.
  • [X] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [ ] N,A, If static libraries are linked in, the license of the static library is packaged.
  • [X] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • [ ] Build number is 0.
  • [X] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [X] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [X] When in trouble, please check our knowledge base documentation before pinging a team.

Old-Shatterhand avatar Oct 17 '24 20:10 Old-Shatterhand

Hi! This is the staged-recipes linter and your PR looks excellent! :rocket:

github-actions[bot] avatar Oct 17 '24 20:10 github-actions[bot]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pywlgk/meta.yaml) and found some lint.

Here's what I've got...

For recipes/pywlgk/meta.yaml:

  • The home item is expected in the about section.

For recipes/pywlgk/meta.yaml:

  • No valid build backend found for Python recipe for package pywlgk using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

conda-forge-admin avatar Oct 17 '24 20:10 conda-forge-admin

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pywlgk/meta.yaml) and found it was in an excellent condition.

conda-forge-admin avatar Oct 17 '24 20:10 conda-forge-admin

@conda-forge/help-python The recipe has passed all checks and is ready for your review. Thanks !

Old-Shatterhand avatar Oct 18 '24 10:10 Old-Shatterhand

@conda-forge/help-python What do I need to do for you to merge this PR? I passed all checked and completed all tasks. About the build number, I'm not sure where to find it, but I guess, it's build 0.

Old-Shatterhand avatar Oct 27 '24 22:10 Old-Shatterhand

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pywlgk/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pywlgk/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the run section of the recipe, you should usually use the pin python >={{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14938679887. Examine the logs at this URL for more detail.

conda-forge-admin avatar Nov 23 '24 15:11 conda-forge-admin

Also, please make the changes requested by the linter.

shermansiu avatar Apr 21 '25 04:04 shermansiu

If no static libraries are linked in, then please check that box off in the checklist.

shermansiu avatar Apr 21 '25 04:04 shermansiu

@shermansiu I checked the boxes and updated the recipe based on the linter's suggestions. Thank you for your help.

Old-Shatterhand avatar May 09 '25 23:05 Old-Shatterhand

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pywlgk/meta.yaml) and found it was in an excellent condition.

conda-forge-admin avatar May 10 '25 22:05 conda-forge-admin

I assume all three prior occurrences of - python {{ python_min }} should be changed to - python >={{ python_min }} too. So, I changed the other two accordingly.

Old-Shatterhand avatar May 10 '25 22:05 Old-Shatterhand

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pywlgk/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pywlgk/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14949547843. Examine the logs at this URL for more detail.

conda-forge-admin avatar May 10 '25 22:05 conda-forge-admin

Ok, with the latest linter, I'm completely confused where to put this python {{ python_min }} and where (or why not) to put python >={{ python_min }} Can you un-confuse me, @shermansiu? Thank you a lot in advance.

Old-Shatterhand avatar May 11 '25 15:05 Old-Shatterhand

@Old-Shatterhand, no, the different sections should have different entries. Commit 1cbde4a was fine and commit b5fa349 should be reverted.

shermansiu avatar May 15 '25 16:05 shermansiu

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pywlgk/meta.yaml) and found it was in an excellent condition.

conda-forge-admin avatar May 15 '25 21:05 conda-forge-admin