staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Biogeme

Open FGarridoV opened this issue 1 year ago • 79 comments

Checklist

  • [ ] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [ ] License file is packaged (see here for an example).
  • [ ] Source is from official source.
  • [ ] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [ ] If static libraries are linked in, the license of the static library is packaged.
  • [ ] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • [ ] Build number is 0.
  • [ ] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [ ] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [ ] When in trouble, please check our knowledge base documentation before pinging a team.

FGarridoV avatar May 16 '24 07:05 FGarridoV

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/biogeme, recipes/biogeme-optimization, recipes/cythonbiogeme) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/biogeme) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/biogeme, recipes/biogeme-optimization, recipes/cythonbiogeme) and found some lint.

Here's what I've got...

For recipes/biogeme:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/biogeme-optimization:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/cythonbiogeme:

  • There are too few lines. There should be one empty line at the end of the file.

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/biogeme, recipes/biogeme-optimization, recipes/cythonbiogeme) and found some lint.

Here's what I've got...

For recipes/biogeme:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/cythonbiogeme:

  • There are too few lines. There should be one empty line at the end of the file.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/biogeme, recipes/biogeme-optimization, recipes/cythonbiogeme) and found it was in an excellent condition.

cythonbiogeme osx failure:

  In file included from /Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716277750463/_build_env/bin/../include/c++/v1/__mbstate_t.h:45:
  /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/sys/_types/_mbstate_t.h:31:9: error: unknown type name '__darwin_mbstate_t'
  typedef __darwin_mbstate_t mbstate_t;
          ^
  1 error generated.
  error: command '/Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716277750463/_build_env/bin/clang++' failed with exit code 1
  error: subprocess-exited-with-error
  
  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

moorepants avatar May 21 '24 16:05 moorepants

cythonbiogeme builds for me locally on linux with the suggested changes I made above.

moorepants avatar May 21 '24 18:05 moorepants

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/biogeme, recipes/biogeme-optimization, recipes/cythonbiogeme) and found some lint.

Here's what I've got...

For recipes/biogeme-optimization:

  • The license item is expected in the about section.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/biogeme, recipes/biogeme-optimization, recipes/cythonbiogeme) and found it was in an excellent condition.

linux_64 failure:

 g++ -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /home/conda/staged-recipes/build_artifacts/cythonbiogeme_1716475747481/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include -fPIC -O2 -isystem /home/conda/staged-recipes/build_artifacts/cythonbiogeme_1716475747481/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/conda/staged-recipes/build_artifacts/cythonbiogeme_1716475747481/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include -fdebug-prefix-map=/home/conda/staged-recipes/build_artifacts/cythonbiogeme_1716475747481/work=/usr/local/src/conda/cythonbiogeme-1.0.2 -fdebug-prefix-map=/home/conda/staged-recipes/build_artifacts/cythonbiogeme_1716475747481/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho=/usr/local/src/conda-prefix -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -isystem /home/conda/staged-recipes/build_artifacts/cythonbiogeme_1716475747481/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include -fPIC -Isrc/cythonbiogeme/cpp -Isrc/ -I/home/conda/staged-recipes/build_artifacts/cythonbiogeme_1716475747481/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.9/site-packages/numpy/core/include -I/home/conda/staged-recipes/build_artifacts/cythonbiogeme_1716475747481/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include/python3.9 -c src/cythonbiogeme/cpp/bioDerivatives.cc -o build/temp.linux-x86_64-cpython-39/src/cythonbiogeme/cpp/bioDerivatives.o -std=c++11
  error: command 'g++' failed: No such file or directory

This builds fine for me locally on linux, so I'm a bit confused why this isn't finding one of the files. I guess it could be possible I have something installed locally that isn't present on the CI service (yet).

moorepants avatar May 23 '24 15:05 moorepants

g++ should be available, not sure why it isn't.

moorepants avatar May 23 '24 15:05 moorepants

Maybe this is overriding the proper path to g++:

if platform.system() == "Darwin":
    os.environ["CC"] = "clang++"
    os.environ["CXX"] = "clang++"
else:
    os.environ["CC"] = "g++"
    os.environ["CXX"] = "g++"

moorepants avatar May 23 '24 15:05 moorepants

For windows, in the github repo there is this:

https://github.com/michelbierlaire/cythonbiogeme/blob/main/setup.cfg

# For Windows
#extra_compile_args = -std=c++11 -DMS_WIN64
#extra_link_args = -static -std=c++11 -static-libstdc++ -static-libgcc -Bstatic -lpthread -mms-bitfields -mwindows -Wl,-Bstatic,--whole-archive -Wl,--no-whole-archive

But it seems removed in the pypi source tarball. We may need to patch to add those link args.

moorepants avatar May 23 '24 15:05 moorepants

Regarding the license. Re: "I'm not sure we can actually distribute this package, given the license." I checked this with Michel Bierlaire (the developer of biogme). He is fine with us building the conda recipe for biogeme.

sandervancranenburgh avatar May 24 '24 06:05 sandervancranenburgh

There is an error in your patch:

Downloading https://pypi.io/packages/source/c/cythonbiogeme/cythonbiogeme-1.0.2.tar.gz
Extracting download
Applying patch: /home/conda/staged-recipes-copy/recipes/cythonbiogeme/setup.py.patch
Applying patch: /home/conda/staged-recipes-copy/recipes/cythonbiogeme/setup.py.patch with args:
['-Np0', '-i', '/tmp/tmp5rw7euwy/setup.py.patch.native', '--binary']
checking file setup.py
patch unexpectedly ends in middle of line
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored
Warning: failed to download source.  If building, will try again after downloading recipe dependencies.

moorepants avatar May 29 '24 12:05 moorepants

I emailed you a patch file that should be correct.

moorepants avatar May 29 '24 12:05 moorepants

osx error:

x86_64-apple-darwin13.4.0-clang -fno-strict-overflow -DNDEBUG -O2 -Wall -fPIC -O2 -isystem /Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/include -fPIC -O2 -isystem /Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/include -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -isystem /Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/include -fdebug-prefix-map=/Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/work=/usr/local/src/conda/cythonbiogeme-1.0.2 -fdebug-prefix-map=/Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place=/usr/local/src/conda-prefix -D_FORTIFY_SOURCE=2 -isystem /Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/include -mmacosx-version-min=10.9 -mmacosx-version-min=10.13 -Isrc/cythonbiogeme/cpp -Isrc/ -I/Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/numpy/core/include -I/Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/include/python3.12 -c src/cythonbiogeme/cpp/bioDerivatives.cc -o build/temp.macosx-10.9-x86_64-cpython-312/src/cythonbiogeme/cpp/bioDerivatives.o -std=c++11
  In file included from src/cythonbiogeme/cpp/bioDerivatives.cc:10:
  In file included from /Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_build_env/bin/../include/c++/v1/iostream:43:
  In file included from /Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_build_env/bin/../include/c++/v1/ios:221:
  In file included from /Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_build_env/bin/../include/c++/v1/__ios/fpos.h:14:
  In file included from /Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_build_env/bin/../include/c++/v1/iosfwd:106:
  In file included from /Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_build_env/bin/../include/c++/v1/__std_mbstate_t.h:14:
  In file included from /Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_build_env/bin/../include/c++/v1/__mbstate_t.h:45:
  /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/sys/_types/_mbstate_t.h:31:9: error: unknown type name '__darwin_mbstate_t'
  typedef __darwin_mbstate_t mbstate_t;
          ^
  1 error generated.
  error: command '/Users/runner/Miniforge3/conda-bld/cythonbiogeme_1716985223014/_build_env/bin/x86_64-apple-darwin13.4.0-clang' failed with exit code 1
  error: subprocess-exited-with-error

moorepants avatar May 29 '24 12:05 moorepants

Windows error:

"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD -Isrc/cythonbiogeme/cpp -Isrc/ -IC:\bld\cythonbiogeme_1716985290432\_h_env\Lib\site-packages\numpy\core\include -IC:\bld\cythonbiogeme_1716985290432\_h_env\include -IC:\bld\cythonbiogeme_1716985290432\_h_env\Include "-IC:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include" "-IC:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\VS\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\um" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\shared" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\winrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\cppwinrt" "-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um" -IC:\bld\cythonbiogeme_1716985290432\_h_env\Library\include -IC:\bld\cythonbiogeme_1716985290432\_h_env\Library\include /d1trimfile:C:\bld\cythonbiogeme_1716985290432\work /EHsc /Tpsrc/cythonbiogeme/cpp/validity_check.cc /Fobuild\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/validity_check.obj -std=c++11
  cl : Command line warning D9002 : ignoring unknown option '-std=c++11'
  validity_check.cc
  "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\link.exe" /nologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:C:\bld\cythonbiogeme_1716985290432\_h_env\libs /LIBPATH:C:\bld\cythonbiogeme_1716985290432\_h_env /LIBPATH:C:\bld\cythonbiogeme_1716985290432\_h_env\PCbuild\amd64 "/LIBPATH:C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.22621.0\ucrt\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\\lib\10.0.22621.0\\um\x64" /LIBPATH:C:\bld\cythonbiogeme_1716985290432\_h_env\Library\lib /LIBPATH:C:\bld\cythonbiogeme_1716985290432\_h_env\Library\lib /EXPORT:PyInit_cythonbiogeme build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioDerivatives.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExceptions.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprAnd.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprBelongsTo.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprConditionalSum.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprCos.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprDerive.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprDivide.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprDraws.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprElem.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprEqual.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprExp.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprFixedParameter.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprFreeParameter.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprGaussHermite.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprGreater.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprGreaterOrEqual.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprIntegrate.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprLess.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprLessOrEqual.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprLinearUtility.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprLiteral.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprLog.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprLogLogit.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprLogLogitFullChoiceSet.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprLogzero.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprMax.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprMin.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprMinus.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprMontecarlo.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprMultSum.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprNormalCdf.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprNotEqual.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprNumeric.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprOr.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprPanelTrajectory.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprPlus.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprPower.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprRandomVariable.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprSin.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprTimes.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprUnaryMinus.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExprVariable.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioExpression.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioFormula.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioGaussHermite.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioGhFunction.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioMemoryManagement.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioNormalCdf.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioSeveralExpressions.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioSeveralFormulas.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioString.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioThreadMemory.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioThreadMemoryOneExpression.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioThreadMemorySimul.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/bioVectorOfDerivatives.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/biogeme.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/cythonbiogeme.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/evaluateExpressions.obj build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp/validity_check.obj /OUT:build\lib.win-amd64-cpython-312\cythonbiogeme\cythonbiogeme.cp312-win_amd64.pyd /IMPLIB:build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp\cythonbiogeme.cp312-win_amd64.lib -std=c++11
  LINK : warning LNK4044: unrecognized option '/std=c++11'; ignored
     Creating library build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp\cythonbiogeme.cp312-win_amd64.lib and object build\temp.win-amd64-cpython-312\Release\src/cythonbiogeme/cpp\cythonbiogeme.cp312-win_amd64.exp
  biogeme.obj : error LNK2001: unresolved external symbol __imp_pthread_join
  biogeme.obj : error LNK2001: unresolved external symbol __imp_pthread_create
  build\lib.win-amd64-cpython-312\cythonbiogeme\cythonbiogeme.cp312-win_amd64.pyd : fatal error LNK1120: 2 unresolved externals
  error: command 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX64\\x64\\link.exe' failed with exit code 1120
  error: subprocess-exited-with-error

moorepants avatar May 29 '24 12:05 moorepants

It seems to be building cythonbiogeme on linux correctly but the CI is in a loop and keeps rebuilding it.

moorepants avatar May 29 '24 12:05 moorepants

This ended up being an error on linux:

nothing provides requested biogeme-optimization 0.0.5.*

not clear why it is search for 0.0.5

moorepants avatar May 29 '24 12:05 moorepants

@FGarridoV I sent you another patch by email.

moorepants avatar May 29 '24 12:05 moorepants

@FGarridoV I sent you another patch by email.

I should also change the version of the "biogeme-optimization ==0.0.5" ?

FGarridoV avatar May 29 '24 12:05 FGarridoV

I should also change the version of the "biogeme-optimization ==0.0.5" ?

If this version of biogeme requires 0.0.5 (exactly) then you should be building biogeme-optimization 0.0.5 in this recipe. If it requires 0.0.6 then you should build that. The recipe and the dependency pin should match in the two recipes.

moorepants avatar May 29 '24 13:05 moorepants

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/biogeme, recipes/biogeme-optimization, recipes/cythonbiogeme) and found some lint.

Here's what I've got...

For recipes/biogeme-optimization:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/cythonbiogeme:

  • The top level meta key patches is unexpected

You seem to have deleted the setup.py.patch you need both patches that I sent you.

moorepants avatar May 29 '24 13:05 moorepants

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/biogeme, recipes/biogeme-optimization, recipes/cythonbiogeme) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/biogeme, recipes/biogeme-optimization, recipes/cythonbiogeme) and found some lint.

Here's what I've got...

For recipes/biogeme:

  • requirements: run: biogeme-optimization == 0.0.5 should not contain a space between relational operator and the version, i.e. biogeme-optimization ==0.0.5

For recipes/biogeme-optimization:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/biogeme, recipes/biogeme-optimization, recipes/cythonbiogeme) and found it was in an excellent condition.

This is the error on linux:

checking file setup.py
patch unexpectedly ends in middle of line
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored
Warning: failed to download source.  If building, will try again after downloading recipe dependencies.
Error was: 
Command '['/opt/conda/bin/patch', '--no-backup-if-mismatch', '--batch', '-Np0', '-i', '/tmp/tmpazud9_jc/setup.py.patch.native', '--binary', '--dry-run']' returned non-zero exit status 1.
Traceback (most recent call last):
  File "/home/conda/staged-recipes-copy/.ci_support/build_all.py", line 261, in <module>
    build_all(os.path.join(root_dir, "recipes"), args.arch)
  File "/home/conda/staged-recipes-copy/.ci_support/build_all.py", line 151, in build_all
    build_folders(recipes_dir, folders, arch, channel_urls)
  File "/home/conda/staged-recipes-copy/.ci_support/build_all.py", line 207, in build_folders
    conda_build.api.build([recipe], config=get_config(arch, channel_urls))
  File "/opt/conda/lib/python3.10/site-packages/conda_build/api.py", line 250, in build
    return build_tree(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 3638, in build_tree
    packages_from_this = build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 2419, in build
    try_download(m, no_download_source=False, raise_error=True)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/render.py", line 779, in try_download
    raise RuntimeError(
RuntimeError: Failed to download or patch source. Please see build log for info.

The patches worked for me when I first sent them to you. I'm not sure what has changed.

moorepants avatar Jun 12 '24 15:06 moorepants

I just tested a linux build locally with the patch files that I emailed you and the build works fine. Are you modifying the patch files or using the wrong ones?

moorepants avatar Jun 12 '24 15:06 moorepants