staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

adding cad-to-dagmc

Open shimwell opened this issue 4 months ago • 9 comments

This PR adds a recipe for cad-to-dagmc. This makes use of an existing conda forge packages (moab, ocp and cadquery) to make files for another conda forge package (dagmc).

Checklist

  • [x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [x] License file is packaged (see here for an example).
  • [x] Source is from official source.
  • [x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [x] If static libraries are linked in, the license of the static library is packaged.
  • [x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • [x] Build number is 0.
  • [x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [x] When in trouble, please check our knowledge base documentation before pinging a team.

shimwell avatar Mar 19 '24 00:03 shimwell

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cad_to_dagmc) and found some lint.

Here's what I've got...

For recipes/cad_to_dagmc:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cad_to_dagmc) and found it was in an excellent condition.

@conda-forge/help-python ready for review. Many thanks

shimwell avatar Mar 19 '24 08:03 shimwell

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cad_to_dagmc) and found some lint.

Here's what I've got...

For recipes/cad_to_dagmc:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cad_to_dagmc) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cad_to_dagmc) and found some lint.

Here's what I've got...

For recipes/cad_to_dagmc:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cad_to_dagmc) and found it was in an excellent condition.

If windows fails because of a dependency issue, this is OK. We are building noarch packages on Linux. It simply means people will not be able to install the package on Windows as long as the dependency doesn't exist.

xhochy avatar Mar 22 '24 15:03 xhochy

If windows fails because of a dependency issue, this is OK. We are building noarch packages on Linux. It simply means people will not be able to install the package on Windows as long as the dependency doesn't exist.

Thanks for letting me know. I shall go back to making this a noarch.

shimwell avatar Mar 22 '24 16:03 shimwell