staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Add tsplib95 and python-tsp.

Open moorepants opened this issue 2 years ago • 6 comments

Checklist

  • [x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [x] License file is packaged (see here for an example).
  • [x] Source is from official source.
  • [x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [ ] If static libraries are linked in, the license of the static library is packaged.
  • [x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • [x] Build number is 0.
  • [x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [ ] When in trouble, please check our knowledge base documentation before pinging a team.

moorepants avatar Jan 17 '24 14:01 moorepants

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/python-tsp, recipes/tsplib95) and found it was in an excellent condition.

@conda-forge/help-python this is ready for review, thanks.

moorepants avatar Jan 17 '24 16:01 moorepants

ping @conda-forge/help-python this one should need minimal review, just two noarch packages with nothing complex.

moorepants avatar Feb 03 '24 07:02 moorepants

ping @conda-forge/help-python can this be merged? I can ask upstream to include the data files for a future release.

moorepants avatar Mar 15 '24 08:03 moorepants

If the file is available via git(hub) you could either use the tarball or for a single file from github the raw.githubcontent.com URL.

xhochy avatar Mar 16 '24 09:03 xhochy

What is the issue about including this file? I've included files like this in many other feedstocks over the years.

moorepants avatar Mar 16 '24 11:03 moorepants

Hi, I removed this data file for the package test and download it instead from the raw git url. Is there anything else I need to adjust? Thanks.

moorepants avatar Apr 10 '24 13:04 moorepants

@conda-forge/help-python I've tried to address all comments. I think this PR is ready, can it be merged? Thanks.

moorepants avatar Apr 21 '24 13:04 moorepants

Dear @conda-forge/help-python, can this PR be merged? It is a simple noarch copy of a PyPi package.

moorepants avatar May 04 '24 06:05 moorepants

Thanks @ocefpaf !

moorepants avatar May 04 '24 10:05 moorepants