staged-recipes
staged-recipes copied to clipboard
Adding mdsapt
Checklist
- [x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
- [x] License file is packaged (see here for an example).
- [x] Source is from official source.
- [x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
- ~~[ ] If static libraries are linked in, the license of the static library is packaged.~~ N/A
- [x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
- [x] Build number is 0.
- [x] A tarball (
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details). - [x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
- [x] When in trouble, please check our knowledge base documentation before pinging a team.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt
) and found some lint.
Here's what I've got...
For recipes/mdsapt:
- The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].
- There are too few lines. There should be one empty line at the end of the file.
- The extra section contained an unexpected subsection name. maintainers is not a valid subsection name.
-
requirements: run: psi4=1.8.1=*_2
must contain a space between the name and the pin, i.e.psi4 =1.8.1=*_2
- noarch: python recipes are required to have a lower bound on the python version. Typically this means putting
python >=3.6
in bothhost
andrun
but you should check upstream for the package's Python compatibility.
For recipes/mdsapt:
- License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.
Documentation on acceptable licenses can be found here.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt
) and found some lint.
Here's what I've got...
For recipes/mdsapt:
- There are too few lines. There should be one empty line at the end of the file.
- The extra section contained an unexpected subsection name. maintainers is not a valid subsection name.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt
) and found some lint.
Here's what I've got...
For recipes/mdsapt:
- There are too few lines. There should be one empty line at the end of the file.
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt
) and found it was in an excellent condition.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt
) and found some lint.
Here's what I've got...
For recipes/mdsapt:
- The following maintainers have not yet confirmed that they are willing to be listed here: ALescoulie. Please ask them to comment on this PR if they are.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt
) and found some lint.
Here's what I've got...
For recipes/mdsapt:
- Selectors are suggested to take a
<two spaces>#<one space>[<expression>]
form. See lines [12, 35] - The following maintainers have not yet confirmed that they are willing to be listed here: ALescoulie. Please ask them to comment on this PR if they are.
- The test section contained an unexpected subsection name. skip is not a valid subsection name.
-
noarch
packages can't have skips with selectors. If the selectors are necessary, please removenoarch: python
.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt
) and found some lint.
Here's what I've got...
For recipes/mdsapt:
- The following maintainers have not yet confirmed that they are willing to be listed here: ALescoulie. Please ask them to comment on this PR if they are.
- Non noarch packages should have python requirement without any version constraints.
- Non noarch packages should have python requirement without any version constraints.
@ALescoulie do you want to be listed as a maintainer?
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt
) and found some lint.
Here's what I've got...
For recipes/mdsapt:
- The following maintainers have not yet confirmed that they are willing to be listed here: ALescoulie. Please ask them to comment on this PR if they are.
@ALescoulie do you want to be listed as a maintainer?
yes I'd like to be a maintainer
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt
) and found it was in an excellent condition.
@conda-forge/staged-recipes, ready for review
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!
@conda-forge/help-python
Hi @xhochy , I made the noarch change, could you look over this again?