staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

added grape to the recipes

Open zommiommy opened this issue 2 years ago • 3 comments

Hi there, I'm one of the authors of grape. I'm trying to make it available on conda, this is the basic recipe.

Our library depends on ensmallen which is highly non-trivial to compile so we just upload the pre-compiled versions on PyPI for Linux, Mac, and Windows. Therefore we don't have a "source" distribution.

I'm not sure what's the best practice, should we try to package also the sub-libraries or could these just be retrieved through PyPi?

Thank you!

zommiommy avatar Oct 07 '22 18:10 zommiommy

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/grape) and found some lint.

Here's what I've got...

For recipes/grape:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

conda-forge-linter avatar Oct 07 '22 18:10 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/grape) and found some lint.

Here's what I've got...

For recipes/grape:

  • requirements: host: python>=3.7 must contain a space between the name and the pin, i.e. python >=3.7
  • requirements: run: python>=3.7 must contain a space between the name and the pin, i.e. python >=3.7
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

conda-forge-linter avatar Oct 07 '22 18:10 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/grape) and found it was in an excellent condition.

conda-forge-linter avatar Oct 07 '22 18:10 conda-forge-linter

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

stale[bot] avatar Mar 25 '23 13:03 stale[bot]

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

stale[bot] avatar Apr 26 '23 18:04 stale[bot]