staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Add igwn-lldd-common and igwn-lldd-fdio

Open rhyspoulton opened this issue 2 years ago • 9 comments

Checklist

  • [x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [x] License file is packaged (see here for an example).
  • [x] Source is from official source.
  • [x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [x] If static libraries are linked in, the license of the static library is packaged.
  • [x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • [x] Build number is 0.
  • [x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [x] When in trouble, please check our knowledge base documentation before pinging a team.

rhyspoulton avatar Oct 04 '22 08:10 rhyspoulton

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/igwn-lldd-common) and found some lint.

Here's what I've got...

For recipes/igwn-lldd-common:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

conda-forge-linter avatar Oct 04 '22 08:10 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/igwn-lldd-common) and found it was in an excellent condition.

conda-forge-linter avatar Oct 04 '22 09:10 conda-forge-linter

@duncanmmacleod two questions:

  1. Are you happy to be added as a maintainer of this recipe?
  2. Do you know why the win_64 check failed? : https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=577555&view=logs&j=240f1fee-52bc-5498-a14a-8361bde76ba0&t=2fb5b0a7-737c-5f5c-8f3f-f6db6174bacf

rhyspoulton avatar Oct 04 '22 11:10 rhyspoulton

@duncanmmacleod two questions:

  1. Are you happy to be added as a maintainer of this recipe?

Yes, I am happy to be named.

  1. Do you know why the win_64 check failed? : https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=577555&view=logs&j=240f1fee-52bc-5498-a14a-8361bde76ba0&t=2fb5b0a7-737c-5f5c-8f3f-f6db6174bacf

I think it's because you haven't declared the entry points in the conda recipe.

duncanmmacleod avatar Oct 11 '22 08:10 duncanmmacleod

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/igwn-lldd-common, recipes/igwn-lldd-fdio) and found it was in an excellent condition.

conda-forge-linter avatar Oct 12 '22 07:10 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/igwn-lldd-common, recipes/igwn-lldd-fdio) and found some lint.

Here's what I've got...

For recipes/igwn-lldd-fdio:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

conda-forge-linter avatar Oct 12 '22 08:10 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/igwn-lldd-common, recipes/igwn-lldd-fdio) and found some lint.

Here's what I've got...

For recipes/igwn-lldd-fdio:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

conda-forge-linter avatar Oct 12 '22 08:10 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/igwn-lldd-common, recipes/igwn-lldd-fdio) and found it was in an excellent condition.

conda-forge-linter avatar Oct 12 '22 08:10 conda-forge-linter

@conda-forge/help-python , this recipe is ready for review. The OSX and WIN build fail for igwn-lldd-fdio due to pyfd and pythonvirgotools not being available in these distributions.

rhyspoulton avatar Oct 12 '22 09:10 rhyspoulton

@conda-forge/staged-recipes, is someone able to review this recipe?

As @rhyspoulton notes the non-linux builds fail because of dependency issues, but the packages are all noarch:python.

duncanmmacleod avatar Oct 27 '22 09:10 duncanmmacleod

Ping @conda-forge/staged-recipes, please review, thanks.

duncanmmacleod avatar Nov 03 '22 08:11 duncanmmacleod