staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Published 20 hours ago • verified publisher icon conda-forge

Adding jupyterlab-h5web

Open t20100 opened this issue 2 years ago • 4 comments

jupyterlab-h5web depends on h5grove which packaging is proposed in PR #20357.

Checklist

  • [x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [x] License file is packaged (see here for an example).
  • [x] Source is from official source.
  • [x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [x] If static libraries are linked in, the license of the static library is packaged.
  • [x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • [x] Build number is 0.
  • [x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [x] When in trouble, please check our knowledge base documentation before pinging a team.

t20100 avatar Sep 09 '22 13:09 t20100

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/jupyterlab-h5web) and found it was in an excellent condition.

conda-forge-linter avatar Sep 09 '22 13:09 conda-forge-linter

Ok being a maintainer

loichuder avatar Sep 12 '22 07:09 loichuder

@conda-forge/help-python, ready for review!

I tested locally by installing from the CI noarch artifact and it works.

I have some questions:

  • The license and the copyright in the license file is only for this package, but since in embeds the webapp bundle which is built from a lot of npm packages. Is this an issue?
  • I copied the tests from jupyterlab-git feedstock and moved them to run_test.* to make it pass on Windows. Are the tests really needed on Windows? If I understand well, no-arch packages are then built on linux only.

t20100 avatar Sep 16 '22 14:09 t20100

Looking at other react-based jupyterlab extensions, only the license of the project is advertised in meta.yml. I guess using dependencies from npm does not need to be advertised here.

t20100 avatar Oct 06 '22 13:10 t20100

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/jupyterlab-h5web) and found some lint.

Here's what I've got...

For recipes/jupyterlab-h5web:

  • Feedstock with the same name exists in conda-forge.

For recipes/jupyterlab-h5web:

  • A conda package with same name (jupyterlab-h5web) already exists.

conda-forge-linter avatar Nov 30 '22 11:11 conda-forge-linter

Closing since it has been added to conda-forge in the mean time: https://github.com/conda-forge/jupyterlab-h5web-feedstock/

t20100 avatar Nov 30 '22 11:11 t20100