staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Added pex as a package

Open thewchan opened this issue 2 years ago • 5 comments

Checklist

  • [ ] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [ ] License file is packaged (see here for an example).
  • [ ] Source is from official source.
  • [ ] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [ ] If static libraries are linked in, the license of the static library is packaged.
  • [ ] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • [ ] Build number is 0.
  • [ ] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [ ] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [ ] When in trouble, please check our knowledge base documentation before pinging a team.

thewchan avatar Aug 20 '22 02:08 thewchan

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pex) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pex:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-linter avatar Aug 20 '22 02:08 conda-forge-linter

@conda-forge/staged-recipes Grayskull detected multiple licenses, these are for vendor package at first glance these all these to be available on conda-forge, so not sure if they needed to be packaged in? Unsure what's the best practice is.

thewchan avatar Aug 20 '22 02:08 thewchan

@conda-forge-admin, please restart ci

thewchan avatar Aug 20 '22 02:08 thewchan

The win build fails because this depends on the linux/mac only fcntl, it is noarch otherwise. @conda-forge/staged-recipes review appreciated!

thewchan avatar Aug 20 '22 03:08 thewchan

Unsure what's the best practice is.

If possible, they should be unvendored and replaced with normal dependencies. Easiest would be if upstream unvendors them, otherwise you can also add a patch here. You would need to check the code structure before though to see how they are used internally.

BastianZim avatar Sep 29 '22 14:09 BastianZim

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

stale[bot] avatar Mar 28 '23 23:03 stale[bot]

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

stale[bot] avatar Jan 01 '24 00:01 stale[bot]

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

stale[bot] avatar Feb 11 '24 01:02 stale[bot]