Adding mmg, iscd tools

[ldallolio]

Checklist

• [X] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
• [X] License file is packaged (see here for an example).
• [X] Source is from official source.
• [X] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
• [X] If static libraries are linked in, the license of the static library is packaged.
• [X] Build number is 0.
• [X] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
• [ ] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
• [X] When in trouble, please check our knowledge base documentation before pinging a team.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/Advection, recipes/Commons, recipes/LinearElasticity, recipes/Mshdist, recipes/mmg) and found some lint.

Here's what I've got...

For recipes/Advection:

• Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [21, 22]

For recipes/Commons:

• Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [22, 23]

For recipes/LinearElasticity:

• Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [21]

For recipes/Mshdist:

• Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [24]

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/Advection, recipes/Commons, recipes/LinearElasticity, recipes/Mshdist, recipes/mmg) and found it was in an excellent condition.

[ldallolio]

@conda-forge/staged-recipes : could you please review ? Thank you !

[bryanloz-xilinx]

Just a note from stuff I've learned in CMake.

Instead of directly calling a platform's Make or NMake command, you can use cmake platform independent commands.

i.e. instead of: https://github.com/conda-forge/staged-recipes/pull/19324/files#diff-8685d56953fcb189f1586b6ea5a55849672e0dac80945a3aa4d360028f4e46f8R4

You can do: https://github.com/Xilinx/XRT/blob/master/build/build.bat#L186

I think... unless there is something special I don't know about NMake.

[ldallolio]

Just a note from stuff I've learned in CMake.

Instead of directly calling a platform's Make or NMake command, you can use cmake platform independent commands.

i.e. instead of: https://github.com/conda-forge/staged-recipes/pull/19324/files#diff-8685d56953fcb189f1586b6ea5a55849672e0dac80945a3aa4d360028f4e46f8R4

You can do: https://github.com/Xilinx/XRT/blob/master/build/build.bat#L186

I think... unless there is something special I don't know about NMake.

Thanks for the advice : I did not know about that and I really like these generalizations, I just switched to the cmake --build and cmake --install syntax :)

[carterbox]

How does mmgsuite get the source of / link to iscd tools? git sub_modules? download during the build process?

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/Advection, recipes/Commons, recipes/LinearElasticity, recipes/Mshdist, recipes/mmg) and found some lint.

Here's what I've got...

For recipes/Commons:

• The recipe must have some tests.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/Advection, recipes/Commons, recipes/LinearElasticity, recipes/Mshdist, recipes/mmg) and found it was in an excellent condition.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/Advection, recipes/Commons, recipes/LinearElasticity, recipes/Mshdist, recipes/NavierStokes, recipes/mmg) and found some lint.

Here's what I've got...

For recipes/Advection:

• When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
• There are too few lines. There should be one empty line at the end of the file.

For recipes/Commons:

• There are too few lines. There should be one empty line at the end of the file.

For recipes/LinearElasticity:

• There are too few lines. There should be one empty line at the end of the file.

For recipes/Mshdist:

• There are too few lines. There should be one empty line at the end of the file.

For recipes/NavierStokes:

• There are too few lines. There should be one empty line at the end of the file.

For recipes/mmg:

• There are too few lines. There should be one empty line at the end of the file.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/Advection, recipes/Commons, recipes/LinearElasticity, recipes/Mshdist, recipes/NavierStokes, recipes/mmg) and found it was in an excellent condition.

[ldallolio]

Hi Daniel,

I am unsure to fully understand this question but, in my mind :

• the only relationship between mmgsuite and iscd tools is by conda dependency mechanism, I am not aware of a download during the build process or git submodules being used.
• I do not understand why I have to whitelist some libraries (they should be taken from the conda dependencies...)

So it is not very clear to me what happens : is it related to the conda forge build system or the mmgsuite code ?

Any help or hint is more than welcome! :)

Il giorno sab 16 lug 2022 alle ore 01:53 Daniel Ching < @.***> ha scritto:

How does mmgsuite get the source of / link to iscd tools? git sub_modules? download during the build process?

— Reply to this email directly, view it on GitHub https://github.com/conda-forge/staged-recipes/pull/19324#issuecomment-1186028318, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPAUDMMOQPUSCV6Y75SSKLVUH2WDANCNFSM5ZD64KMA . You are receiving this because you authored the thread.Message ID: @.***>

[stale[bot]]

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/Advection, recipes/Commons, recipes/LinearElasticity, recipes/Mshdist, recipes/NavierStokes, recipes/mmg) and found it was in an excellent condition.

[ldallolio]

Hi, After a full-weekend work, I think I fixed the issues with this MR. Could you please review and tell me if I need to do something else? Thanks! All the best @conda-forge-admin, please ping team

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/Advection, recipes/Commons, recipes/LinearElasticity, recipes/Mshdist, recipes/NavierStokes, recipes/mmg) and found some lint.

Here's what I've got...

For recipes/mmg:

• pin_compatible should be used instead of pin_subpackage for iscd-linearelasticity because it is not a known output of this recipe: ['mmgsuite'].
• pin_compatible should be used instead of pin_subpackage for iscd-linearelasticity because it is not a known output of this recipe: ['mmgsuite'].

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/Advection, recipes/Commons, recipes/LinearElasticity, recipes/Mshdist, recipes/NavierStokes, recipes/mmg) and found it was in an excellent condition.

[fbordeu]

ok to be recipe-maintainer

[carterbox]

Also, please ping the team for review, not individuals.