staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Adding freefem

Open ldallolio opened this issue 2 years ago • 9 comments

Checklist

  • [X] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [X] License file is packaged (see here for an example).
  • [X] Source is from official source.
  • [X] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [X] If static libraries are linked in, the license of the static library is packaged.
  • [X] Build number is 0.
  • [X] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [X] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [X] When in trouble, please check our knowledge base documentation before pinging a team.

ldallolio avatar Jun 17 '22 07:06 ldallolio

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/freefem-feedstock) and found some lint.

Here's what I've got...

For recipes/freefem-feedstock:

  • There are too few lines. There should be one empty line at the end of the file.
  • If python is a host requirement, it should be a run requirement.

For recipes/freefem-feedstock:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-linter avatar Jun 17 '22 07:06 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/freefem-feedstock) and found it was in an excellent condition.

conda-forge-linter avatar Jun 17 '22 07:06 conda-forge-linter

@conda-forge/staged-recipes : could you please review ? Thanks !

ldallolio avatar Jun 17 '22 08:06 ldallolio

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/freefem-feedstock) and found some lint.

Here's what I've got...

For recipes/freefem-feedstock:

  • If python is a host requirement, it should be a run requirement.

conda-forge-linter avatar Jul 09 '22 19:07 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/freefem-feedstock) and found it was in an excellent condition.

conda-forge-linter avatar Jul 09 '22 20:07 conda-forge-linter

@conda-forge/help-c-cpp, this autconf/make package is linking to libraries in $BUILD_PREFIX instead of $PREFIX. Which is causing error's like:

  ERROR (freefem,lib/ff++/4.10/lib/Schur-Complement.so): $PATH/lib/libgcc_s.so.1 found in build prefix; should never happen

Any ideas on how to avoid these errors?

carterbox avatar Jul 12 '22 01:07 carterbox

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/freefem-feedstock) and found some lint.

Here's what I've got...

For recipes/freefem-feedstock:

  • The top level meta key run is unexpected

conda-forge-linter avatar Aug 09 '22 06:08 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/freefem-feedstock) and found it was in an excellent condition.

conda-forge-linter avatar Aug 09 '22 06:08 conda-forge-linter

I confirm I am willing maintainer

cnrdn avatar Aug 14 '22 20:08 cnrdn