staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Add spatialpy recipe

Open seanebum opened this issue 2 years ago • 11 comments

Checklist

  • [x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [x] License file is packaged (see here for an example).
  • [x] Source is from official source.
  • [ ] ~~Package does not vendor other packages.~~ Vendors two packages: ANN and NRM! (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [x] If static libraries are linked in, the license of the static library is packaged.
  • [x] Build number is 0.
  • [x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [x] When in trouble, please check our knowledge base documentation before pinging a team.

seanebum avatar Jun 10 '22 20:06 seanebum

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/SpatialPy) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/SpatialPy:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

conda-forge-linter avatar Jun 10 '22 20:06 conda-forge-linter

I am willing to be a maintainer

briandrawert avatar Jun 10 '22 21:06 briandrawert

I am willing to be listed here

seanebum avatar Jun 10 '22 21:06 seanebum

I am willing to be a maintainer

BryanRumsey avatar Jun 10 '22 21:06 BryanRumsey

@conda-forge/help-python

Ready for review, Thank you!

seanebum avatar Jun 14 '22 16:06 seanebum

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/SpatialPy) and found it was in an excellent condition.

conda-forge-linter avatar Jul 13 '22 17:07 conda-forge-linter

@conda-forge/help-python Ready for review, suggestions have been implemented. Thanks again!

seanebum avatar Jul 14 '22 16:07 seanebum

This is part of the package, it is not a separate project.

briandrawert avatar Jul 23 '22 15:07 briandrawert

Good to know.

  1. Can you explain why this python package ships uncompiled C source files? Conda packages are expected to be pre-compiled unless there is some JIT mechanism, but in that case your package would also depend on a compiler package.

  2. We don't allow revendoring of external projects without good justification. This project is revendoring ANN and NRM. ANN is already available on conda-forge.

carterbox avatar Jul 25 '22 19:07 carterbox

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/SpatialPy) and found some lint.

Here's what I've got...

For recipes/SpatialPy:

  • The requirements/ sections should be defined in the following order: build, host, run; instead saw: host, build, run.

conda-forge-linter avatar Aug 15 '22 17:08 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/SpatialPy) and found it was in an excellent condition.

conda-forge-linter avatar Aug 15 '22 17:08 conda-forge-linter

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

stale[bot] avatar Apr 13 '23 03:04 stale[bot]

@conda-forge-admin, please ping team

We would still like to include this in conda-forge. Review comments about vendoring other packages are incorrect. NRM is NOT a separate package (not found in any other codebase). ANN has been heavily modified to work with our system. Our build infrastructure can not be changed. Please let us know how we can get this package included.

briandrawert avatar Apr 13 '23 18:04 briandrawert

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/SpatialPy) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/SpatialPy) and found some lint.

Here's what I've got...

For recipes/SpatialPy:

  • Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

NRM is NOT a separate package (not found in any other codebase).

My mistake.

ANN has been heavily modified to work with our system. Our build infrastructure can not be changed. Please let us know how we can get this package included.

If it's heavily modified to the point that the canonical ANN doesn't work, that's good justification. However, please add the path of the license for ANN to the license section of this recipe!

We have added the licence file for ANN.

Can you explain why this python package ships uncompiled C source files? Conda packages are expected to be pre-compiled unless there is some JIT mechanism, but in that case your package would also depend on a compiler package.

SpatialPy is compiled at run time and does depend on a C++ compiler. We have looked through the conda-forge documentation on how to specify this in the requirements, and have not found the solution. Please let us know what the proper format is for this entry: https://github.com/conda-forge/staged-recipes/blob/22544ec8a62d59ca45067e67296a2d5ba196cfe0/recipes/SpatialPy/meta.yaml#L33

briandrawert avatar Apr 18 '23 17:04 briandrawert

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/SpatialPy) and found some lint.

Here's what I've got...

For recipes/SpatialPy:

  • requirements: run: scons >= 4.4.0 should not contain a space between relational operator and the version, i.e. scons >=4.4.0

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/SpatialPy) and found it was in an excellent condition.

@conda-forge-admin, please ping team

Comments resolved.

briandrawert avatar Apr 27 '23 20:04 briandrawert

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

stale[bot] avatar Dec 31 '23 21:12 stale[bot]

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

stale[bot] avatar Feb 11 '24 02:02 stale[bot]