staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Add Neuraxle

Open guillaume-chevalier opened this issue 4 years ago • 11 comments

python @conda-forge/help-python

@conda-forge/help-python

@conda-forge-admin, please ping team

Checklist

  • [x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • [x] License file is packaged (see here for an example)
  • [x] Source is from official source
  • [x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • [x] If static libraries are linked in, the license of the static library is packaged.
  • [x] Build number is 0
  • [x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • [x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

guillaume-chevalier avatar Oct 17 '21 21:10 guillaume-chevalier

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

conda-forge-linter avatar Oct 17 '21 21:10 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/neuraxle) and found some lint.

Here's what I've got...

For recipes/neuraxle:

  • requirements: run: numpy>=1.16.2 must contain a space between the name and the pin, i.e. numpy >=1.16.2
  • requirements: run: scipy>=1.4.1 must contain a space between the name and the pin, i.e. scipy >=1.4.1
  • requirements: run: scikit-learn>=0.24.1 must contain a space between the name and the pin, i.e. scikit-learn >=0.24.1
  • requirements: run: matplotlib==3.3.4 must contain a space between the name and the pin, i.e. matplotlib ==3.3.4
  • requirements: run: joblib>=0.13.2 must contain a space between the name and the pin, i.e. joblib >=0.13.2
  • requirements: run: Flask>=1.1.4 must contain a space between the name and the pin, i.e. Flask >=1.1.4
  • requirements: run: Flask-RESTful>=0.3.7 must contain a space between the name and the pin, i.e. Flask-RESTful >=0.3.7
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

conda-forge-linter avatar Oct 17 '21 21:10 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/neuraxle) and found some lint.

Here's what I've got...

For recipes/neuraxle:

  • Invalid noarch value python >=. Should be one of python, generic.

conda-forge-linter avatar Oct 18 '21 21:10 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/neuraxle) and found it was in an excellent condition.

conda-forge-linter avatar Oct 18 '21 21:10 conda-forge-linter

Nice!

@conda-forge/help-python @conda-forge-admin, please ping team

guillaume-chevalier avatar Oct 18 '21 21:10 guillaume-chevalier

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

conda-forge-linter avatar Oct 18 '21 21:10 conda-forge-linter

Could also skip Windows and revisit in the feedstock

jakirkham avatar Mar 22 '22 09:03 jakirkham

I should be able to deploy a new version of this library in the next week with lots of heavy changes. I'd love to get this merged afterwards @jakirkham, with or without windows support.

guillaume-chevalier avatar Mar 31 '22 02:03 guillaume-chevalier

@jakirkham or could you merge now the existing version without Windows, and we'd also merge the next version? Can you do this?

guillaume-chevalier avatar Mar 31 '22 02:03 guillaume-chevalier

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/neuraxle) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/neuraxle:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

conda-forge-linter avatar Jul 22 '22 04:07 conda-forge-linter

@jakirkham, I get the following error in the CI pipelines: RuntimeError: Did not find any source_files for test with pattern testing

Not sure how to fix it.

Would this be due to the fact that I used the PyPI image rather than the GitHub tar image? Normally I can run tests from the pytest command using a test subfolder as described here

guillaume-chevalier avatar Aug 16 '22 20:08 guillaume-chevalier

Filed issue ( https://github.com/Neuraxio/Neuraxle/issues/530 ) outlining the issue and a possible fix

jakirkham avatar Aug 17 '22 05:08 jakirkham

@jakirkham Thanks for filing the issue.

I was wondering, could it be possible to use the GitHub repository for fetching the test folder, or using just the GitHub repository directly without having to include the testing folder and the examples folder in the sdist? E.g. using a GitHub tarball from the git tag e.g. 0.8.1 without any reference to PyPI in the conda forge script?

Trying to avoid redeploying and including the test folder. Adding the testing_neuraxle folder would also prossibly require to add the examples folder which it depends on. Trying to avoid people being able to do like from examples.this_and_that import main, I fear it would pollute the IDEs of people using the library with lots of detected symbols that they will never import.

Thanks!

guillaume-chevalier avatar Aug 18 '22 17:08 guillaume-chevalier

Yes that can be done and may be reasonable in the short term. Though would suggest fixing that upstream packaging issue.

It is worth noting that GitHub archives are autogenerated when requested. So do not necessarily have stable checksums (changes in timestamps or other metadata could cause the checksum of the archive to change).

jakirkham avatar Aug 18 '22 18:08 jakirkham

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

stale[bot] avatar Apr 13 '23 02:04 stale[bot]

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

stale[bot] avatar May 13 '23 18:05 stale[bot]