staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Add openEO recipe

Open sebastian-luna-valero opened this issue 3 years ago • 14 comments

Checklist

  • [X] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [X] License file is packaged (see here for an example).
  • [X] Source is from official source.
  • [X] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [X] If static libraries are linked in, the license of the static library is packaged.
  • [X] Build number is 0.
  • [X] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [X] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [X] When in trouble, please check our knowledge base documentation before pinging a team.

sebastian-luna-valero avatar Jul 22 '21 07:07 sebastian-luna-valero

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/openeo) and found it was in an excellent condition.

conda-forge-linter avatar Jul 22 '21 07:07 conda-forge-linter

Great, tests are now passing for both Linux and OSX.

Is there an interest in supporting Windows as well?

sebastian-luna-valero avatar Aug 31 '21 16:08 sebastian-luna-valero

@conda-forge/help-python please review.

sebastian-luna-valero avatar Oct 04 '21 15:10 sebastian-luna-valero

@conda-forge/staged-recipes please review.

sebastian-luna-valero avatar Oct 05 '21 11:10 sebastian-luna-valero

@conda-forge-admin, please ping team

sebastian-luna-valero avatar Oct 06 '21 15:10 sebastian-luna-valero

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

conda-forge-linter avatar Oct 06 '21 15:10 conda-forge-linter

Hi @dopplershift

Could you confirm whether this recipe can be merged, please?

Best regards, Sebastian

sebastian-luna-valero avatar Oct 11 '21 13:10 sebastian-luna-valero

Update: testing version v0.9.2 of openEO python client on Windows produces:

FAILED tests/test_util.py::test_get_user_config_dir - AssertionError: assert ...
FAILED tests/test_util.py::test_get_user_data_dir - AssertionError: assert Wi...
FAILED tests/rest/auth/test_cli.py::test_paths - AssertionError: assert '/aut...
FAILED tests/rest/auth/test_config.py::TestPrivateJsonFile::test_permissions
FAILED tests/rest/auth/test_config.py::TestPrivateJsonFile::test_wrong_permissions
FAILED tests/rest/auth/test_config.py::TestRefreshTokenStorage::test_public_file
FAILED tests/rest/auth/test_config.py::TestRefreshTokenStorage::test_permissions

See the details here.

Linux and OSX builds are passing the tests.

sebastian-luna-valero avatar Apr 01 '22 08:04 sebastian-luna-valero

Update: testing version v0.10.0 on Windows produces:

FAILED tests/test_config.py::test_get_user_config_dir - AssertionError: asser...
FAILED tests/test_config.py::test_get_user_data_dir - AssertionError: assert ...
FAILED tests/test_config.py::test_get_config_verbose[print-False-True] - re.e...
FAILED tests/test_config.py::test_get_config_verbose[print-True-True] - re.er...
FAILED tests/test_config.py::test_get_config_verbose[auto-False-False] - re.e...
FAILED tests/test_config.py::test_get_config_verbose[auto-True-True] - re.err...
FAILED tests/test_config.py::test_get_config_verbose[off-False-False] - re.er...
FAILED tests/test_config.py::test_get_config_verbose[off-True-False] - re.err...
FAILED tests/rest/auth/test_cli.py::test_paths - AssertionError: assert '/aut...
FAILED tests/rest/auth/test_config.py::TestPrivateJsonFile::test_permissions
FAILED tests/rest/auth/test_config.py::TestPrivateJsonFile::test_wrong_permissions
FAILED tests/rest/auth/test_config.py::TestRefreshTokenStorage::test_public_file
FAILED tests/rest/auth/test_config.py::TestRefreshTokenStorage::test_permissions

See details here.

Linux and OSX builds are passing the tests.

sebastian-luna-valero avatar Apr 12 '22 13:04 sebastian-luna-valero

Update: testing version v0.10.1 on Windows produces:

FAILED tests/test_config.py::test_get_user_config_dir - AssertionError: asser...
FAILED tests/test_config.py::test_get_user_data_dir - AssertionError: assert ...
FAILED tests/test_config.py::test_get_config_verbose[print-False-True] - re.e...
FAILED tests/test_config.py::test_get_config_verbose[print-True-True] - re.er...
FAILED tests/test_config.py::test_get_config_verbose[auto-False-False] - re.e...
FAILED tests/test_config.py::test_get_config_verbose[auto-True-True] - re.err...
FAILED tests/test_config.py::test_get_config_verbose[off-False-False] - re.er...
FAILED tests/test_config.py::test_get_config_verbose[off-True-False] - re.err...
FAILED tests/rest/auth/test_cli.py::test_paths - AssertionError: assert '/aut...
FAILED tests/rest/auth/test_config.py::TestPrivateJsonFile::test_permissions
FAILED tests/rest/auth/test_config.py::TestPrivateJsonFile::test_wrong_permissions
FAILED tests/rest/auth/test_config.py::TestRefreshTokenStorage::test_public_file
FAILED tests/rest/auth/test_config.py::TestRefreshTokenStorage::test_permissions

See details here.

Linux and OSX builds are passing the tests.

sebastian-luna-valero avatar May 18 '22 09:05 sebastian-luna-valero

Below are the results of the tests for v0.11.0.

Linux tests are now failing with:

FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf]

OSX tests are now failing with:

FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf]

Windows tests are failing with:

FAILED tests/test_config.py::test_get_user_config_dir - AssertionError: asser...
FAILED tests/test_config.py::test_get_user_data_dir - AssertionError: assert ...
FAILED tests/test_config.py::test_get_config_verbose[print-False-True] - re.e...
FAILED tests/test_config.py::test_get_config_verbose[print-True-True] - re.er...
FAILED tests/test_config.py::test_get_config_verbose[auto-False-False] - re.e...
FAILED tests/test_config.py::test_get_config_verbose[auto-True-True] - re.err...
FAILED tests/test_config.py::test_get_config_verbose[off-False-False] - re.er...
FAILED tests/test_config.py::test_get_config_verbose[off-True-False] - re.err...
FAILED tests/rest/auth/test_cli.py::test_paths - AssertionError: assert '/aut...
FAILED tests/rest/auth/test_config.py::TestPrivateJsonFile::test_permissions
FAILED tests/rest/auth/test_config.py::TestPrivateJsonFile::test_wrong_permissions
FAILED tests/rest/auth/test_config.py::TestRefreshTokenStorage::test_public_file
FAILED tests/rest/auth/test_config.py::TestRefreshTokenStorage::test_permissions
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf]

sebastian-luna-valero avatar Jul 04 '22 07:07 sebastian-luna-valero

Below are the results of the tests for v0.12.0.

Linux tests:

FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf]

OSX tests:

FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf]

Windows tests:

FAILED tests/test_config.py::test_get_user_config_dir - AssertionError: asser...
FAILED tests/test_config.py::test_get_user_data_dir - AssertionError: assert ...
FAILED tests/test_config.py::test_get_config_verbose[print-False-True] - re.e...
FAILED tests/test_config.py::test_get_config_verbose[print-True-True] - re.er...
FAILED tests/test_config.py::test_get_config_verbose[auto-False-False] - re.e...
FAILED tests/test_config.py::test_get_config_verbose[auto-True-True] - re.err...
FAILED tests/test_config.py::test_get_config_verbose[off-False-False] - re.er...
FAILED tests/test_config.py::test_get_config_verbose[off-True-False] - re.err...
FAILED tests/rest/auth/test_cli.py::test_paths - AssertionError: assert '/aut...
FAILED tests/rest/auth/test_config.py::TestPrivateJsonFile::test_permissions
FAILED tests/rest/auth/test_config.py::TestPrivateJsonFile::test_wrong_permissions
FAILED tests/rest/auth/test_config.py::TestRefreshTokenStorage::test_public_file
FAILED tests/rest/auth/test_config.py::TestRefreshTokenStorage::test_permissions
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf]

sebastian-luna-valero avatar Sep 13 '22 05:09 sebastian-luna-valero

The results for the tests for v0.12.1 are the same as for v0.12.0

sebastian-luna-valero avatar Sep 15 '22 12:09 sebastian-luna-valero

Tests results for v0.13.0 are the same as for v0.12.0.

sebastian-luna-valero avatar Oct 11 '22 15:10 sebastian-luna-valero

FYI, as noted in https://github.com/Open-EO/openeo-python-client/issues/176 : Windows unit test support should now be fixed.

Fixes are merged in master branch, but not yet in a release (will be 0.13.1 probably)

refs: https://github.com/Open-EO/openeo-python-client/issues/198, https://github.com/Open-EO/openeo-python-client/issues/350, https://github.com/Open-EO/openeo-python-client/pull/354, https://github.com/Open-EO/openeo-python-client/pull/351

soxofaan avatar Jan 04 '23 15:01 soxofaan

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/openeo) and found it was in an excellent condition.

Thanks!

I just rebuilt using the master branch and here are the results.

Linux tests:

=========================== short test summary info ============================
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf] - AssertionError: assert dtype('int32') == <class 'numpy.int64'>
 +  where dtype('int32') = <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b'.dtype
 +    where <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b' = <XarrayDataCube shape:(3, 2, 4, 5)>.array
 +  and   <class 'numpy.int64'> = numpy.int64
========== 1 failed, 1262 passed, 17 skipped, 190 warnings in 14.68s ===========
Tests failed for openeo-0.13.0-py310hff52083_0.conda - moving package to /home/conda/staged-recipes/build_artifacts/broken
WARNING:conda_build.build:Tests failed for openeo-0.13.0-py310hff52083_0.conda - moving package to /home/conda/staged-recipes/build_artifacts/broken
TESTS FAILED: openeo-0.13.0-py310hff52083_0.conda

OSX tests:

=========================== short test summary info ============================
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf] - AssertionError: assert dtype('int32') == <class 'numpy.int64'>
 +  where dtype('int32') = <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b'.dtype
 +    where <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b' = <XarrayDataCube shape:(3, 2, 4, 5)>.array
 +  and   <class 'numpy.int64'> = numpy.int64
===== 1 failed, 1262 passed, 17 skipped, 190 warnings in 61.09s (0:01:01) ======
Tests failed for openeo-0.13.0-py39h6e9494a_0.conda - moving package to /Users/runner/mambaforge/conda-bld/broken
WARNING:conda_build.build:Tests failed for openeo-0.13.0-py39h6e9494a_0.conda - moving package to /Users/runner/mambaforge/conda-bld/broken
TESTS FAILED: openeo-0.13.0-py39h6e9494a_0.conda

Windows tests:

(%PREFIX%) %SRC_DIR%>pip check 
openeo 0.13.1a3 requires oschmod, which is not installed.

(%PREFIX%) %SRC_DIR%>IF 1 NEQ 0 exit /B 1 

(%PREFIX%) %SRC_DIR%>IF 1 NEQ 0 exit /B 1 
Tests failed for openeo-0.13.0-py38haa244fe_0.conda - moving package to C:\bld\broken
WARNING:conda_build.build:Tests failed for openeo-0.13.0-py38haa244fe_0.conda - moving package to C:\bld\broken
TESTS FAILED: openeo-0.13.0-py38haa244fe_0.conda

sebastian-luna-valero avatar Jan 09 '23 07:01 sebastian-luna-valero

Hmm at the moment, I can not reproduce that failure on linux/mac. My current guess is the recipe adds some additional dependencies that are optional for xarray and change the behavior a bit.

soxofaan avatar Jan 09 '23 17:01 soxofaan

regarding:

(%PREFIX%) %SRC_DIR%>pip check openeo 0.13.1a3 requires oschmod, which is not installed.

the oshmod package is a new dependency, required for windows (and optional for linux/mac). I guess this has to be added to the recipe

soxofaan avatar Jan 09 '23 17:01 soxofaan

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/openeo) and found some lint.

Here's what I've got...

For recipes/openeo:

  • Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

oschmod is only available with pip which cannot be included in the conda recipe.

Adding a conda recipe:

  • https://github.com/YakDriver/oschmod/issues/115
  • https://github.com/conda-forge/staged-recipes/pull/21692

sebastian-luna-valero avatar Jan 10 '23 07:01 sebastian-luna-valero

Hmm at the moment, I can not reproduce that failure on linux/mac. My current guess is the recipe adds some additional dependencies that are optional for xarray and change the behavior a bit.

Could you please narrow down the difference so we can replicate your environment here?

sebastian-luna-valero avatar Jan 10 '23 07:01 sebastian-luna-valero

I finetuned those failing linux/mac tests under https://github.com/Open-EO/openeo-python-client/issues/359 which hopefully should clarify better what is going on here (made save/load netcdf engines more explicit in tests)

can you try to rerun with latest master?

soxofaan avatar Jan 10 '23 12:01 soxofaan

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/openeo) and found it was in an excellent condition.

Here is the new output:

FAILED tests/udf/test_xarraydatacube.py::test_save_load_full[netcdf-h5netcdf-scipy] - TypeError: Error: /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_save_load_full_netcdf_h5n1/cube.netcdf is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,

            netcdf4 library, e.g.,

            $ pip install netcdf4
FAILED tests/udf/test_xarraydatacube.py::test_save_load_no_time_dim[netcdf-scipy-h5netcdf] - OSError: Unable to open file (file signature not found)
FAILED tests/udf/test_xarraydatacube.py::test_save_load_no_xy_labels[netcdf-h5netcdf-scipy] - TypeError: Error: /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_save_load_no_xy_labels_ne2/cube.netcdf is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,

            $ pip install netcdf4
FAILED tests/udf/test_xarraydatacube.py::test_save_load_no_xy_labels[netcdf-scipy-h5netcdf] - OSError: Unable to open file (file signature not found)
FAILED tests/udf/test_xarraydatacube.py::test_save_load_no_xy_dim[netcdf-h5netcdf-scipy] - TypeError: Error: /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_save_load_no_xy_dim_netcd2/cube.netcdf is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,

            $ pip install netcdf4
FAILED tests/udf/test_xarraydatacube.py::test_save_load_no_xy_dim[netcdf-scipy-h5netcdf] - OSError: Unable to open file (file signature not found)
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf-defaults] - AssertionError: assert dtype('int32') == <class 'numpy.int64'>
 +  where dtype('int32') = <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b'.dtype
 +    where <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b' = <XarrayDataCube shape:(3, 2, 4, 5)>.array
 +  and   <class 'numpy.int64'> = numpy.int64
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf-h5netcdf-scipy] - TypeError: Error: /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_save_load_dtype_int64_net2/cube.netcdf is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,

            $ pip install netcdf4
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf-scipy-h5netcdf] - OSError: Unable to open file (file signature not found)
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf-scipy-scipy] - AssertionError: assert dtype('int32') == <class 'numpy.int64'>
 +  where dtype('int32') = <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b'.dtype
 +    where <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b' = <XarrayDataCube shape:(3, 2, 4, 5)>.array
 +  and   <class 'numpy.int64'> = numpy.int64
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_float64[netcdf-h5netcdf-scipy] - TypeError: Error: /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_save_load_dtype_float64_n2/cube.netcdf is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,

            $ pip install netcdf4
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_float64[netcdf-scipy-h5netcdf] - OSError: Unable to open file (file signature not found)

Should I simply add netcdf4 to the requirements to address these issues? If so, any specific version?

sebastian-luna-valero avatar Jan 10 '23 13:01 sebastian-luna-valero

indeed, for our regular test runs we depend on netCDF4: https://github.com/Open-EO/openeo-python-client/blob/d640bdeb796d438a42bef295089a025d14334168/setup.py#L24

If I understand correctly , it's this scipy engine that is causing the failures. Any idea why where scipy comes from, because I don't see it listed as dependency?

soxofaan avatar Jan 10 '23 15:01 soxofaan

scipy is a dependency for geopandas, which is included in the list of dependencies for the tests.

sebastian-luna-valero avatar Jan 10 '23 15:01 sebastian-luna-valero

Here is the output after adding netCDF4:

=========================== short test summary info ============================
FAILED tests/udf/test_xarraydatacube.py::test_save_load_full[netcdf-netcdf4-scipy] - TypeError: Error: /tmp/pytest-of-conda/pytest-0/test_save_load_full_netcdf_net2/cube.netcdf is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,
FAILED tests/udf/test_xarraydatacube.py::test_save_load_no_xy_dim[netcdf-h5netcdf-scipy] - TypeError: Error: /tmp/pytest-of-conda/pytest-0/test_save_load_no_xy_dim_netcd6/cube.netcdf is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,

            $ pip install netcdf4
FAILED tests/udf/test_xarraydatacube.py::test_save_load_no_xy_dim[netcdf-scipy-h5netcdf] - OSError: Unable to open file (file signature not found)
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf-netcdf4-scipy] - TypeError: Error: /tmp/pytest-of-conda/pytest-0/test_save_load_dtype_int64_net3/cube.netcdf is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,

            $ pip install netcdf4
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf-h5netcdf-scipy] - TypeError: Error: /tmp/pytest-of-conda/pytest-0/test_save_load_dtype_int64_net6/cube.netcdf is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,

            $ pip install netcdf4
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf-scipy-netcdf4] - AssertionError: assert dtype('int32') == <class 'numpy.int64'>
 +  where dtype('int32') = <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b'.dtype
 +    where <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b' = <XarrayDataCube shape:(3, 2, 4, 5)>.array
 +  and   <class 'numpy.int64'> = numpy.int64
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf-scipy-h5netcdf] - OSError: Unable to open file (file signature not found)
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_int64[netcdf-scipy-scipy] - AssertionError: assert dtype('int32') == <class 'numpy.int64'>
 +  where dtype('int32') = <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b'.dtype
 +    where <xarray.DataArray (t: 3, bands: 2, x: 4, y: 5)>\narray([[[[   0,    1,    2,    3,    4],\n         [  10,   11,   12,  ...nt32 5 6 7 8 9\n  * x        (x) int32 2 3 4 5\n  * t        (t) int32 2019 2020 2021\n  * bands    (bands) object 'a' 'b' = <XarrayDataCube shape:(3, 2, 4, 5)>.array
 +  and   <class 'numpy.int64'> = numpy.int64
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_float64[netcdf-netcdf4-scipy] - TypeError: Error: /tmp/pytest-of-conda/pytest-0/test_save_load_dtype_float64_n3/cube.netcdf is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,

            $ pip install netcdf4
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_float64[netcdf-h5netcdf-scipy] - TypeError: Error: /tmp/pytest-of-conda/pytest-0/test_save_load_dtype_float64_n6/cube.netcdf is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,

            $ pip install netcdf4
FAILED tests/udf/test_xarraydatacube.py::test_save_load_dtype_float64[netcdf-scipy-h5netcdf] - OSError: Unable to open file (file signature not found)
========== 23 failed, 1305 passed, 44 skipped, 193 warnings in 15.35s ==========

sebastian-luna-valero avatar Jan 10 '23 15:01 sebastian-luna-valero

@soxofaan could you please check test failures for v0.14.0 in: https://dev.azure.com/conda-forge/84710dde-1620-425b-80d0-4cf5baca359d/_build/results?buildId=651255

and let me know what can I do to help?

sebastian-luna-valero avatar Feb 02 '23 09:02 sebastian-luna-valero

Apparently it's the limited netcdf support of the scipy engine that is causing the issues.

scipy is a dependency for geopandas

FYI: in my local virtual env (and the github actions envs) scipy is not installed as dependency of geopandas. Is that a dependency introduced by conda?

as quickfix I'm going to blacklist the scipy netcdf engine for the tests

soxofaan avatar Feb 02 '23 10:02 soxofaan