staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

Added libonnx recipe

Open AnthonyBarbier opened this issue 4 years ago • 12 comments

Checklist

  • [x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • [x] License file is packaged (see here for an example)
  • [x] Source is from official source
  • [x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • [x] If static libraries are linked in, the license of the static library is packaged.
  • [x] Build number is 0
  • [x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • [x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

AnthonyBarbier avatar Nov 05 '20 14:11 AnthonyBarbier

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libonnx) and found some lint.

Here's what I've got...

For recipes/libonnx:

  • There are 1 too many lines. There should be one empty line at the end of the file.
  • If python is a host requirement, it should be a run requirement.

conda-forge-linter avatar Nov 05 '20 14:11 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libonnx) and found some lint.

Here's what I've got...

For recipes/libonnx:

  • There are 1 too many lines. There should be one empty line at the end of the file.

conda-forge-linter avatar Nov 05 '20 14:11 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libonnx) and found some lint.

Here's what I've got...

For recipes/libonnx:

  • There are 2 too many lines. There should be one empty line at the end of the file.

conda-forge-linter avatar Nov 05 '20 14:11 conda-forge-linter

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libonnx) and found it was in an excellent condition.

conda-forge-linter avatar Nov 05 '20 14:11 conda-forge-linter

Ping @conda-forge/help-c-cpp: this is ready for review.

AnthonyBarbier avatar Nov 06 '20 18:11 AnthonyBarbier

@conda-forge/staged-recipes : this is ready for review. (Sorry not sure which one I was supposed to use)

AnthonyBarbier avatar Nov 06 '20 18:11 AnthonyBarbier

I believe this recipe should be part of the onnx as an output What do you think @ocefpaf ?

https://github.com/conda-forge/onnx-feedstock

marcelotrevisani avatar Nov 09 '20 17:11 marcelotrevisani

Could you please open a PR on this feedstock? https://github.com/conda-forge/onnx-feedstock

Here you can find some information how to write outputs: https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#outputs-section

marcelotrevisani avatar Nov 09 '20 17:11 marcelotrevisani

I believe this recipe should be part of the onnx as an output What do you think @ocefpaf ?

Makes sense. Our fuzzy name linter did not catch this one. Thanks @marcelotrevisani!!

ocefpaf avatar Nov 09 '20 17:11 ocefpaf

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

stale[bot] avatar Apr 08 '21 19:04 stale[bot]

@ocefpaf @marcelotrevisani As far as I understand libonnx is independent of Python and thus we would build it several time if we add it as an output to the onnx-feedstock? I'm happy to do this work but as I currently struggle a bit with the mixed CI dimension in the xgboost-feedstock, I wouldn't like to create that situation again for libonnx.

xhochy avatar Apr 14 '21 14:04 xhochy

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

stale[bot] avatar Aug 12 '22 02:08 stale[bot]

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

stale[bot] avatar Sep 20 '22 04:09 stale[bot]