conda-smithy icon indicating copy to clipboard operation
conda-smithy copied to clipboard

incorrect linter complaint: "Please do not delete the example recipe"

Open ctb opened this issue 3 years ago • 2 comments

If the added recipe is not under recipes/, the linter incorrectly complains that the example recipe has been deleted.


details

Over in https://github.com/conda-forge/staged-recipes/pull/12983, I got a lint error,

Please do not delete the example recipe found in recipes/example/meta.yaml.

which was confusing because I hadn't :). Turned out the problem was I'd put my recipe in the wrong location, under the root directory of the repo and not under recipes. This became clear later on during the build, but the linter got it wrong.

I fixed this by moving bbhash/meta.yaml over to recipes/bbhash/meta.yaml in https://github.com/conda-forge/staged-recipes/pull/12983/commits/5ea8f77e58611edb0b47a0d5128decc837d975f6.

ping @conda-forge/staged-recipes

ctb avatar Oct 24 '20 15:10 ctb

p.s. and thank you for conda-forge :)

ctb avatar Oct 24 '20 15:10 ctb

@ctb - The code for this is over in the conda-smithy repo, so we may consider moving this discussion there. The code specifically is:

https://github.com/conda-forge/conda-smithy/blob/master/conda_smithy/lint_recipe.py#L748-L762

It looks like somehow the recipe_dir assignment must get confused and then it looks for the example/meta.yaml in the wrong place. I'd have to dig a bit more to figure out what it's actually being set to in this case and how that might fail.

synapticarbors avatar Oct 24 '20 15:10 synapticarbors