conda-smithy
conda-smithy copied to clipboard
conda-forge
Shorten config & job names
I found the names that are generated for CI jobs a bit difficult to parse, e.g., here:
with this change, they look a bit nicer to me:
TODO:
- [ ] Bring back platform-target
- [ ] Write NEWS
- [ ] More tests
I’m not in favor of this. Knowing where each config var comes from is useful.
I’m not in favor of this. Knowing where each config var comes from is useful.
Ok. Then what about doing this only for specific variables such as python_impl?
Yes. Things that are obvious could be shortened like python or python_impl
I think I still like this more aggressive approach better as it's hard to maintain a list of "boring" variables. There are quite a few variables that change over time that we don't show here anyway, such as the global pinnings.
For the feedstocks that I am actively maintaining, I know what the possible combinations are and if I doubt it I personally always look at the config or the CI output to understand which combination I am looking at. But maybe that's just me :)
@beckermr, @scopatz: I now gave it a default list of variables and the option for maintainers to modify them.
Just to clarify, I started doing this because I had two comments where people thought that something was wrong with a feedstock or conda-smithy because the CI names look broken.
Sure I get that. We could do better on extra underscores for example. But having the variable names in the config file path is very useful especially for the build-locally script where those config names appear as options in the script.