conda-forge.github.io icon indicating copy to clipboard operation
conda-forge.github.io copied to clipboard

Explain how to accept conda-forge invitation

Open jakirkham opened this issue 8 years ago • 9 comments

Quite frequently we find ourselves explaining how to accept a GitHub organization invitation. Given this, we should add it to the docs. Possibly with links to relevant GitHub pages. That way we can reference it when it comes up again.

jakirkham avatar Oct 31 '17 07:10 jakirkham

I think it would probably be good to have a little bit more in general of "my pull request's been merged, now what?" docs, including this, that we can just link to when we merge a staged-recipes PR. Basically also saying that the feedstock repo will be made, but it might take a little while, etc etc.

djsutherland avatar Nov 02 '17 13:11 djsutherland

Those docs could also directly link to an article to update the package later.

kain88-de avatar Nov 03 '17 18:11 kain88-de

Stealing from @isuruf, maybe we can add this link: https://github.com/orgs/conda-forge/invitation

jakirkham avatar Apr 27 '18 18:04 jakirkham

Also have had luck telling people to go to the org webpage and look for invite details in the banner at the top.

jakirkham avatar Apr 27 '18 18:04 jakirkham

@jakirkham has the exact right of it.

Despite having successfully received GitHub organization invitations in the past, I failed to receive either a confirmatory e-mail or a GitHub notification for the conda-forge invitation. Which meant that I then had to waste everyone's time yet again by complaining like a miserable sea hag. To lazily copy-pasta myself:

According to a pertinent StackOverflow thread (again generously supplied by @isuruf), this really is a widespread GitHub API and/or UX issue. Organization invitations occasionally fail non-deterministically, for reasons no one knows. Some GitHubbers sporadically get hit by it. Some don't.

On the bright side, this isn't conda-forge's fault. On the dark side, you probably want to publish that link. A FAQ entry might be the short-term answer; an automated comment appended to the bottom of any newly accepted pull request might be the long-term answer.

leycec avatar Apr 28 '18 06:04 leycec

So we now have an automated welcome message thanks to @isuruf's work. 🎉

Here's an example of a recent one. We can tweak that message. We can also add something in the docs that we link to from that message.

Please share your thoughts. :)

jakirkham avatar May 26 '18 03:05 jakirkham

This is indeed fantastic. Appending message text specific to each new user (if any) was a mystifyingly clever stroke of genius. You even handled the obnoxious edge case of English plurals properly. Aside from the lack of support for Klingon localization, I am left without complaints. How can it be?

Let us rejoice on this rare occasion. Bravo, @isuruf and @jakirkham!

leycec avatar Jun 05 '18 06:06 leycec

@jakirkham Are docs still needed with the automated welcome message being created?

kathatherine avatar Jun 03 '22 21:06 kathatherine

People still miss that email and it'd be good to have the link in the docs and mention that if the invitation is expired (github recently reduced the time from 6 months to a couple of weeks), the people should do https://conda-forge.org/docs/maintainer/infrastructure.html#conda-forge-admin-please-update-team to get an updated invitation.

isuruf avatar Jun 03 '22 21:06 isuruf