conda-forge.github.io icon indicating copy to clipboard operation
conda-forge.github.io copied to clipboard

Search bar very closed to footer in the website

Open Aaishpra opened this issue 3 years ago • 17 comments

Issue: The search bar is very closed to the footer on the website, some space is needed. to make it look better image

Aaishpra avatar Apr 11 '21 12:04 Aaishpra

@viniciusdc I am not sure how to add space here can you help? Also since I opened this I would like to work on it.

Aaishpra avatar Apr 11 '21 12:04 Aaishpra

Even I am interested to know how to work on improving the user interface, (though it is auto-generated) but I guess their must have been repo to improve the sphinx set-up. not sure tho😅.

prachinandi avatar Apr 11 '21 12:04 prachinandi

@prachi237 Although some small changes can be made in the theme using conf.py but not all. Let's see what @viniciusdc says about this.

Aaishpra avatar Apr 11 '21 13:04 Aaishpra

@prachi237 Although some small changes can be made in the theme using conf.py but not all. Let's see what @viniciusdc says about this.

Hi, about the search bar it depends on the monitor you are using for it. But to change it's configuration there was an issue somewhere implementing this

viniciusdc avatar Apr 11 '21 15:04 viniciusdc

@viniciusdc I would like to take up on this issue. I think I know where the issue is coming from.

angeloobeta avatar Apr 11 '21 18:04 angeloobeta

@viniciusdc I would like to take up on this issue. I think I know where the issue is coming from.

Great, as @Aaishpra requested this first, she has priority in this. But @angeloobeta if you don't mind, both can try to solve this (there is also a problem when oppening the docs in the cellphone) and I will consider this contribution to both of you :)

viniciusdc avatar Apr 11 '21 20:04 viniciusdc

Ya sure @angeloobeta can work with me. @angeloobeta do you have any suggestions how to approach this?

Aaishpra avatar Apr 12 '21 06:04 Aaishpra

(there is also a problem when oppening the docs in the cellphone) and I will consider this contribution to both of you :)

@viniciusdc i just opened the docs in my phone and found what you are talking about shall i open the issue for this.

Aaishpra avatar Apr 12 '21 06:04 Aaishpra

(there is also a problem when oppening the docs in the cellphone) and I will consider this contribution to both of you :)

@viniciusdc i just opened the docs in my phone and found what you are talking about shall i open the issue for this.

Hi @Aaishpra, yes I think it could be a good idea, at least for us to have that documented somewhere. About the solution it may lie inside the sphinx-cloud theme we use for the docs...

viniciusdc avatar Apr 12 '21 13:04 viniciusdc

Ya sure @angeloobeta can work with me. @angeloobeta do you have any suggestions how to approach this?

@Aaishpra Besides that, I do remember an old issue (closed) implementing the search bar, I will try to find that later, but it might help you both.

viniciusdc avatar Apr 12 '21 13:04 viniciusdc

Thanks, I have also opened the issue (for responsiveness problem in phone) and will try searching for the solution in the sphinx-cloud docs you once shared.

Aaishpra avatar Apr 12 '21 16:04 Aaishpra

Ya sure @angeloobeta can work with me. @angeloobeta do you have any suggestions how to approach this?

@Aaishpra, Thank you for asking for my recommendation on how to address these issues; for the two issues you mentioned. I think should first start with the #1371 before heading over to #1358. I think the problem of #1371 is coming from the way bootstrap was set to render the content on mobile view, for issue #1358, we will explorer the spacing in the index_page. what's your take on my suggestions.

angeloobeta avatar Apr 13 '21 01:04 angeloobeta

@angeloobeta actually we can't directly change anything in the sidebar,(in UI terms mainly) other than this the sidebar is also probably auto-generated as we add more headings in documents or .rst files it gets updated, i have been reading sphinx -documentation regarding this and haven't yet found something. Let's see what we can do @viniciusdc searching for the some old issue. Do let me know if you find something regarding this.

Aaishpra avatar Apr 14 '21 06:04 Aaishpra

Linking #1419 here. Need to work upon this one!

PrernaSingh587 avatar Apr 28 '21 15:04 PrernaSingh587

I'm not too knowledgeable in this matter, but I think this old PR that implemented changes to the search engine https://github.com/conda-forge/conda-forge.github.io/pull/531/files might be of some help here, at least as a way to find where those configs were...

viniciusdc avatar Apr 28 '21 15:04 viniciusdc

Great I think adding a little bit of padding in theme.css will solve this Will send out a PR for this then

Aaishpra avatar Apr 28 '21 15:04 Aaishpra

Are there still issues on this repo ?, I will like to work on it.

codewithmike01 avatar Mar 29 '22 17:03 codewithmike01