utopia icon indicating copy to clipboard operation
utopia copied to clipboard

chore(test): remove warnings

Open liady opened this issue 1 year ago • 2 comments

Problem: Today we have a lot of warnings in our Karma output which really clutters it

Fix: This PR tries to address some of them:

  1. import the default export of package.json instead of import * from
  2. change moduleIds from hashed to deterministic (as Webpack recommends)
  3. import { act } from @testing-library/react instead of react-dom/test-utils

Manual Tests: I hereby swear that:

  • [X] I opened a hydrogen project and it loaded
  • [X] I could navigate to various routes in Preview mode

liady avatar Sep 07 '24 10:09 liady

Try me

github-actions[bot] avatar Sep 07 '24 10:09 github-actions[bot]

#15425 Bundle Size — 58.21MiB (-0.02%).

5696d50(current) vs d1d46c1 master#15423(baseline)

[!WARNING] Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#15425
     Baseline
#15423
Improvement  Initial JS 41.18MiB(-0.03%) 41.19MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 100% 18.14%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4190 4190
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.24% 27.24%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#15425
     Baseline
#15423
Improvement  JS 58.2MiB (-0.02%) 58.21MiB
Improvement  HTML 9.4KiB (-0.21%) 9.42KiB

Bundle analysis reportBranch chore/clear-warnsProject dashboard


Generated by RelativeCIDocumentationReport issue

relativeci[bot] avatar Sep 07 '24 10:09 relativeci[bot]

Temporarily closing as a spike to be picked up later

liady avatar Dec 16 '24 14:12 liady