utopia icon indicating copy to clipboard operation
utopia copied to clipboard

fix(grid): dont generate gaps until the placeholder grid was updated

Open liady opened this issue 1 year ago • 2 comments

Problem: Currently since we're relying on the grid metadata for row/column count and on the grid placeholder to get the actual cells, when adding a row/column to the grid via the inspector the metadata is updated before the grid DOM element, which causes a crash when trying to access a non-existing cell

Fix: Wait for the grid placeholder to be consistent with the metadata, otherwise return an empty gap array

  • [X] I opened a hydrogen project and it loaded
  • [X] I could navigate to various routes in Preview mode

liady avatar Aug 29 '24 21:08 liady

Try me

github-actions[bot] avatar Aug 29 '24 21:08 github-actions[bot]

#14019 Bundle Size — 62.54MiB (~+0.01%).

5d531aa(current) vs 916e8b9 master#13980(baseline)

[!WARNING] Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14019
     Baseline
#13980
Regression  Initial JS 45.67MiB(~+0.01%) 45.67MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.63% 21.56%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4377 4377
No change  Duplicate Modules 519 519
No change  Duplicate Code 31.63% 31.63%
No change  Packages 472 472
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14019
     Baseline
#13980
Regression  JS 62.52MiB (~+0.01%) 62.52MiB
Improvement  HTML 11.05KiB (-0.33%) 11.09KiB

Bundle analysis reportBranch fix/inconsistent-cell-countProject dashboard


Generated by RelativeCIDocumentationReport issue

relativeci[bot] avatar Aug 29 '24 21:08 relativeci[bot]