utopia icon indicating copy to clipboard operation
utopia copied to clipboard
verified publisher icon concrete-utopia

Unify our edit permissions mechanism

Open liady opened this issue 1 year ago • 3 comments

A small PR to unify our permissions mechanisms. Instead of using two separate mechanisms (hasEditPermissions and allowedToEditProject) - now the permissions check is in permissions.ts (via the usePermissions hook) and the semantic checks (canEdit, canComment, etc) can be in the specific usage areas.

liady avatar Feb 12 '24 09:02 liady

Try me

github-actions[bot] avatar Feb 12 '24 10:02 github-actions[bot]

Job #10365: Bundle Size — 62.37MiB (~+0.01%).

85b840b(current) vs d299c8d master#10361(baseline)

[!WARNING] Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
Job #10365		      Baseline
Job #10361
Regression  Initial JS 35.4MiB(~+0.01%) 35.4MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.57% 21.79%
No change  Chunks 28 28
No change  Assets 32 32
Change  Modules 4408(+0.02%) 4407
No change  Duplicate Modules 490 490
No change  Duplicate Code 30.7% 30.7%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10365		      Baseline
Job #10361
Regression  JS 62.36MiB (~+0.01%) 62.35MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10365 report View chore/unify-permissions branch activity View project dashboard

relativeci[bot] avatar Feb 12 '24 10:02 relativeci[bot]

Performance test results: (Chart1)
(Chart2)

github-actions[bot] avatar Feb 12 '24 10:02 github-actions[bot]