utopia icon indicating copy to clipboard operation
utopia copied to clipboard

When wrapping in element in 'preserve position' mode, we should understand the layout of the fresh wrapper element

Open balazsbajorics opened this issue 3 years ago • 2 comments

the floating-insert-menu 's wrapping functionality now uses two disgusting functions named getIsFlexBasedOnName_KILLME_EXPERIMENTAL and getIsFlexDirectionBasedOnName_KILLME_SERIOUSLY_EXPERIMENTAL

we need an approach to fix this.

the challenge is that we should somehow know upfront before insertion what kind of layout this mystic wrapper element provide for us

balazsbajorics avatar Jul 23 '21 10:07 balazsbajorics

@balazsbajorics is this still current? Should we close it?

maltenuhn avatar Feb 21 '22 21:02 maltenuhn

@maltenuhn I believe it is still current!

Wrap In... is kind of like a reparenting. and when you reparent across layout systems, now on master we have automatic layout prop conversion. We will probably build something more sophisticated for Strategies.

but I assume even the more sophisticated layout system converter will need to know what is the layout system of the new parent – hence this ticket.

the idea is that somehow during insertion we should figure out the layout of the newly inserted (wrapper) parent, ideally before we draw on the screen.

balazsbajorics avatar Feb 23 '22 09:02 balazsbajorics