git-resource icon indicating copy to clipboard operation
git-resource copied to clipboard

Payload File Should be Readonly by Creator

Open jraffin opened this issue 7 years ago • 0 comments

Hi, I noticed that the creation of the "payload" file in the Check script is not using mktemp() which causes the file to be created with read permissions for others. This is a security vulnerability as it enables someone to potentially read the credentials contained in the "payload" file.

I would like to sugges that payload=$TMPDIR/git-resource-request be replaced with payload=$(mktemp $TMPDIR/git-resource-request.XXXXXX)

for the Check script.

Regards, --Johan

jraffin avatar Sep 27 '18 22:09 jraffin