git-resource icon indicating copy to clipboard operation
git-resource copied to clipboard

Failure not caught when trying to check a tag that is now missing.

Open Samze opened this issue 7 years ago • 2 comments

The previous tag we were building against has now been removed. We found it very difficult to trigger the build for the next tag (had to hijack the container and add the missing tag back to the local repository).

It looks like this line: https://github.com/concourse/git-resource/blob/master/assets/check#L74 will fail if the tag no longer exists in the repo, displaying an error message and returning 129.

As far as we can tell, this failure is not reported anywhere obvious. According to the UI the resource tag filter reports the missing tag.

Thanks, Sam & Steve Freeman

Samze avatar Apr 03 '17 15:04 Samze

Hi there!

We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.

The current status is as follows:

  • [ ] #142958113 Failure not caught when trying to check a tag that is now missing.

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

concourse-bot avatar Apr 03 '17 15:04 concourse-bot

This is something that would be a wonderful PR to accept.

If you're interested, please start by looking at our Contributing Guide

I've also attached this to the Help Wanted milestone.

chendrix avatar May 23 '17 21:05 chendrix