docker-image-resource icon indicating copy to clipboard operation
docker-image-resource copied to clipboard

skip_download does not support boolean in Concourse 4.10

Open samgurtman-zz opened this issue 7 years ago • 3 comments

After upgrading to 4.10, docker-image get failed when skip_download: true. Previously this worked. The workaround is to quote skip_download: 'true'.

samgurtman-zz avatar Sep 16 '18 22:09 samgurtman-zz

I've seen this before elsewhere. I'd guess this is a result of the underlying yaml library expecting yaml 1.1 instead of yaml 1.2.

chrishiestand avatar Oct 11 '18 00:10 chrishiestand

Hmmm ... interesting to know. Had this issue as well. And as you @samgurtman describe, I was able to solve it by just quoting the boolean. Should this be fixed or should it "just" be documented on this resource?

larssb avatar Dec 20 '18 10:12 larssb

With the latest concourse is this still a problem i.e. true needs to be quoted?

I think the problem is not related to yaml 1.1 vs 1.2 since true is a validate boolean in both versions. It should be caused by the go library that concourse used to parse yaml.

xtremerui avatar May 14 '20 15:05 xtremerui