concourse-chart icon indicating copy to clipboard operation
concourse-chart copied to clipboard

fix: Change the "userIDFieldPerConnector" parameter's place

Open pedrodsrodrigues opened this issue 1 year ago • 0 comments

Why do we need this PR?

The concourse-chart/templates/web-deployment.yaml file is looking for Values.concourse.web.auth.userIDFieldPerConnector but the parameter is in concourse.web.auth.mainTeam.userIDFieldPerConnector, according to the documentation.

Changes proposed in this pull request

  • Change the parameter userIDFieldPerConnector to the correct place, which is concourse.web.auth.userIDFieldPerConnector instead of concourse.web.auth.mainTeam.userIDFieldPerConnector (or the opposite, if that's what is decided. But in that case it shouldn't go to the master branch).

Contributor Checklist

  • [x] Variables are documented in the README.md
  • [x] Which branch are you merging into?
    • master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
    • dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

  • [ ] Code reviewed
  • [ ] Topgun tests run
  • [ ] Back-port if needed
  • [ ] Is the correct branch targeted? (master or dev)

pedrodsrodrigues avatar Sep 26 '23 13:09 pedrodsrodrigues