hooks icon indicating copy to clipboard operation
hooks copied to clipboard

[conan-center] Prefer relaxed patch apply

Open prince-chrismc opened this issue 5 years ago • 2 comments

https://github.com/conan-io/conan-center-index/pull/3729/files#diff-0431db5aff9fe6643a51b5fe6d132a4c224a0afbd24d22c50e39b5c88b0f273bL36-L37

This will have better longevity as new releases are less likely to require patching since they are ~usually~ on occasion submitted upstream

prince-chrismc avatar Nov 29 '20 14:11 prince-chrismc

I don't follow. What are you suggesting?

I'm also not sure if it statistically correct that most patches are submitted upstream 🤔

Croydon avatar Nov 29 '20 15:11 Croydon

Still early morning ☕ sorry!

I see the diff below in lots of PRs and I think it's better to start with it so that it does not require a RREV and rebuilding more packages just a small bump would have been sufficient

-for patch in self.conan_data["patches"][self.version]:
+for patch in self.conan_data.get("patches", {}).get(self.version, []):
            tools.patch(**patch)

prince-chrismc avatar Nov 29 '20 15:11 prince-chrismc