hooks icon indicating copy to clipboard operation
hooks copied to clipboard

Published 20 hours ago • verified publisher icon conan-io

Add pybind11 to the whitelist for KB-h016

Open uilianries opened this issue 5 years ago • 6 comments

Related PR: https://github.com/conan-io/conan-center-index/pull/464

/cc @danimtb @madebr

uilianries avatar Jan 15 '20 12:01 uilianries

@danimtb I just update it. Rather than putting pybind11 in whitelist, now any custom find cmake file is allowed. Take a look.

uilianries avatar Jan 16 '20 13:01 uilianries

Seems like the last change related to Python 2.7 affected us. Should we drop the tests involving Python 2.7 ?

uilianries avatar Jan 16 '20 13:01 uilianries

We are not dropping Python 2 support in the CI yet, please see https://github.com/conan-io/hooks/issues/146

danimtb avatar Jan 17 '20 10:01 danimtb

Restarting in 3 .. 2 .. 1 ..

uilianries avatar Jan 27 '20 11:01 uilianries

@uilianries please update this PR with the latest changes in master branch to kick the CI

danimtb avatar Apr 28 '20 09:04 danimtb

Just a note: I am a bit hesitant about the changes in this PR as packages may have other Find*.cmake files to find other libraries. I think we have to make sure that the file is declared in cpp_info.build_modules mandatory, so we are able to see it in the PR diff inside the recipe

danimtb avatar Apr 28 '20 09:04 danimtb