conan-package-tools icon indicating copy to clipboard operation
conan-package-tools copied to clipboard

CONAN_BASE_PROFILE_BUILD is incorrectly passed to docker

Open jmarrec opened this issue 3 years ago • 1 comments

Changelog: (Fix): This is a draft PR that is just a work in progress trying to pass CONAN_BASE_PROFILE_BUILD to docker

Note: This is a draft PR as it currently doesn't work and includes lots of print-debugging (some of which I don't even see in the logs). It is just meant to serve as a point of discussion on #595. It will either be cleaned up or closed.

A failing example of an actual run that uses this patched cpt can be found here: https://github.com/jmarrec/conan-openstudio-ruby/runs/4852398264?check_suite_focus=true

Actual changes without debug-printing: https://github.com/conan-io/conan-package-tools/compare/1fce6c3a42e27022fdeceac6614dfeea85b61f14

  • references https://github.com/conan-io/conan-package-tools/issues/595
  • [ ] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • [x] I've read the Contributing guide.
  • [x] I've followed the PEP8 style guides for Python code.

jmarrec avatar Jan 18 '22 13:01 jmarrec

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 18 '22 13:01 CLAassistant

Is this PR obsolete?

Croydon avatar Oct 27 '22 08:10 Croydon

@Croydon Non functional rather, but the need is still here, though I've worked around it since then. I'm fine closing if no one has the bandwith to help out finish it though.

jmarrec avatar Oct 28 '22 06:10 jmarrec

I don't understand the issue currently, the CI logs got deleted in the meantime and the referenced issue closed as solved 🤔

Croydon avatar Oct 28 '22 07:10 Croydon

Meh, let's assume it's fine. Closing then :)

jmarrec avatar Oct 31 '22 14:10 jmarrec