conan-package-tools
conan-package-tools copied to clipboard
CONAN_UPLOAD_DEPENDENCIES fails if dependency Doesn't have user and channel
Description of Problem, Request, or Question
Uploading dependency which doesn't have a username and channel fails. The newer packages provided by conan center don't have @user/channel suffix eg sqlite/3.29.0 and if you try to upload that dependency on the CI by specifying CONAN_UPLOAD_DEPENDENCIES="sqlite3/3.29.0" it fails as it asks for confirmation.
I've dug down the problem to conans/client/cmd/uploader.py the upload function sets confirm to true depending on what check_valid_ref tells it. And apparently it is not a valid ref in strict mode so the uploader doesn't set the confirm flag and there is a user prompt to confirm which fails on the CI.
Environment Details
- Docker image: conanio/gcc8:1.18.5
Steps to reproduce (Include if Applicable)
Build https://github.com/bincrafters/conan-qt using conan package tools with CONAN_BUILD_POLICY=missing and CONAN_UPLOAD_DEPENDENCIES="sqlite3/3.29.0"
Build logs (Include if Available)
Log is full of 2019-10-17T15:06:04.158608197Z stdout P e you want to upload 'sqlite3/3.29.0' to 'upload_repo'? (yes/no)
@pinak is this bug still relevant? I have seen on my side, that dependencies without user or channel (/) are uploaded via CONAN_UPLOAD_DEPENDENCIES. seen with conan-package-tools 0.37.0 and conan 1.42.0